AB#32008 Reduce Office extraction Sonar complexity#2088
Merged
JamesPasta merged 2 commits intodevfrom Mar 6, 2026
Merged
Conversation
jacobwillsmith
requested review from
AndreGAot,
JamesPasta,
hasanpour and
ligovbc
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
approved these changes
Mar 6, 2026
JamesPasta
deleted the
feature/AB#32008-AddOfficeExtractionSupport-SonarFixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This pull request addresses SonarQube maintainability findings in Office document text extraction by simplifying row/sheet processing flow and reducing method complexity in
TextExtractionService.The update keeps extraction behavior and limits unchanged while making the code easier to reason about and maintain.
Changes:
usingdirectives and aligned implementation with SonarQube recommendations