Skip to content

AB#32008 Reduce Office extraction Sonar complexity #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesPasta merged 2 commits into from
Mar 6, 2026
Merged

AB#32008 Reduce Office extraction Sonar complexity #2088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff3866
AB#32008 Reduce Office extraction Sonar complexity
jacobwillsmith Mar 4, 2026
96097ac
AB#32008 Apply Office extraction Sonar cleanup
jacobwillsmith Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 62 additions & 38 deletions ...cations/Unity.GrantManager/src/Unity.GrantManager.Application/AI/TextExtractionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using NPOI.SS.UserModel;
using NPOI.XWPF.UserModel;
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
Expand Down Expand Up @@ -220,52 +219,19 @@ private string ExtractTextFromExcelFile(string fileName, byte[] fileContent)
using var workbook = WorkbookFactory.Create(stream);
var builder = new StringBuilder();
var sheetCount = Math.Min(workbook.NumberOfSheets, MaxExcelSheets);
var limitReached = false;

for (var sheetIndex = 0; sheetIndex < sheetCount; sheetIndex++)
{
if (limitReached || builder.Length >= MaxExtractedTextLength)
if (builder.Length >= MaxExtractedTextLength)
{
break;
}

var sheet = workbook.GetSheetAt(sheetIndex);
if (sheet == null)
{
continue;
}

var processedRows = 0;
foreach (IRow row in sheet)
var limitReached = TryAppendExcelSheet(sheet, builder);
if (limitReached)
{
if (processedRows >= MaxExcelRowsPerSheet || builder.Length >= MaxExtractedTextLength)
{
break;
}

var rowHasValue = false;
foreach (var cell in row.Cells.Take(MaxExcelCellsPerRow))
{
var value = GetCellText(cell);
if (string.IsNullOrWhiteSpace(value))
{
continue;
}

var separator = rowHasValue ? " | " : (builder.Length > 0 ? Environment.NewLine : null);
limitReached = AppendWithLimit(builder, value, MaxExtractedTextLength, separator);
rowHasValue = true;
if (limitReached)
{
break;
}
}

processedRows++;
if (limitReached)
{
break;
}
break;
}
}

Expand All @@ -278,6 +244,64 @@ private string ExtractTextFromExcelFile(string fileName, byte[] fileContent)
}
}

private static bool TryAppendExcelSheet(ISheet? sheet, StringBuilder builder)
{
if (sheet == null)
{
return false;
}

var processedRows = 0;
foreach (IRow row in sheet)
{
if (processedRows >= MaxExcelRowsPerSheet || builder.Length >= MaxExtractedTextLength)
{
break;
}

var limitReached = TryAppendExcelRow(row, builder);
processedRows++;
if (limitReached)
{
return true;
}
}

return builder.Length >= MaxExtractedTextLength;
}

private static bool TryAppendExcelRow(IRow row, StringBuilder builder)
{
var rowHasValue = false;
foreach (var cell in row.Cells.Take(MaxExcelCellsPerRow))
{
var value = GetCellText(cell);
if (string.IsNullOrWhiteSpace(value))
{
continue;
}

string? separator = null;
if (rowHasValue)
{
separator = " | ";
}
else if (builder.Length > 0)
{
separator = Environment.NewLine;
}

var limitReached = AppendWithLimit(builder, value, MaxExtractedTextLength, separator);
rowHasValue = true;
if (limitReached)
{
return true;
}
}

return false;
}

private static bool AppendWithLimit(StringBuilder builder, string? value, int maxLength, string? separator = null)
{
if (string.IsNullOrWhiteSpace(value))
Expand Down
Loading