Bugfix/ab#33047 collapse dismissed ai analysis sections#2473
Merged
jacobwillsmith merged 2 commits intoMay 15, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the AI Analysis sections on the Grant Application Details page so sections with no visible items (e.g., all items dismissed/hidden) collapse and cannot be expanded into an empty section body.
Changes:
- Refactors “visible analysis items” detection into a shared helper and reuses it for layout + collapse logic.
- Disables the section collapse toggle when there are no visible items and forces the section into a collapsed state.
- Adds a disabled visual style for the collapse toggle button.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/Details.css | Adds styling for disabled state of the AI analysis collapse toggle. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/ai-analysis.js | Centralizes visible-item lookup and updates collapse behavior based on visible items, including disabling the collapse control. |
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
jacobwillsmith
force-pushed
the
bugfix/AB#33047-collapse-dismissed-ai-analysis-sections
branch
from
22ada98 to
113cd56
Compare
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
hasanpour
approved these changes
May 15, 2026
jacobwillsmith
deleted the
bugfix/AB#33047-collapse-dismissed-ai-analysis-sections
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes AI Application Analysis sections so they collapse when no items are visible and cannot be expanded into an empty body.
Changes