Skip to content

Bugfix/ab#33047 collapse dismissed ai analysis sections #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobwillsmith merged 2 commits into from
May 15, 2026
Merged

Bugfix/ab#33047 collapse dismissed ai analysis sections #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
235e031
AB#33047 collapse dismissed AI analysis sections
jacobwillsmith May 15, 2026
113cd56
AB#33047 collapse dismissed AI analysis sections
jacobwillsmith May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...cations/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/Details.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,11 +538,6 @@ form label.error {
line-height: 1.6;
}

.ai-analysis-section.compact .ai-analysis-section-body {
padding-top: 10px;
padding-bottom: 10px;
}

.ai-analysis-section.header-only .ai-analysis-section-body {
display: none;
}
Expand Down Expand Up @@ -645,6 +640,12 @@ form label.error {
background-color: #eef2f6;
}

.ai-analysis-collapse-toggle:disabled {
color: #9ca3af;
cursor: default;
pointer-events: none;
}

.ai-analysis-collapse-toggle:focus,
.ai-analysis-collapse-toggle:focus-visible {
outline: none;
Expand Down
55 changes: 39 additions & 16 deletions ...ions/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/ai-analysis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,20 @@ function createFindingItem(item, type, hidden) {

function updateVisibleItemLayout($items) {
const $allItems = $items.children('.ai-analysis-detail-item');
const $visibleItems = $allItems.filter(function() {
return this.style.display !== 'none';
});
const $visibleItems = getVisibleAnalysisItems($items);

$allItems.removeClass('last-visible');
$visibleItems.last().addClass('last-visible');
}

function getVisibleAnalysisItems($items) {
return $items
.children('.ai-analysis-detail-item')
.filter(function() {
return this.style.display !== 'none';
});
}

function formatSectionTitle(title, count) {
return `${title} (${count})`;
}
Expand All @@ -164,21 +170,37 @@ function configureSectionStatus($status, text, statusClass) {
.show();
}

function configureCollapseToggle($section, $collapseToggle) {
function setSectionCollapsed($section, $collapseToggle, isCollapsed) {
const labels = getAnalysisLabels();
const $icon = $collapseToggle.find('i');

$section.toggleClass('collapsed', isCollapsed);
$collapseToggle
.attr('aria-expanded', (!isCollapsed).toString())
.attr('title', isCollapsed ? labels.expandTitle : labels.collapseTitle);

$icon
.toggleClass('fa-chevron-down', !isCollapsed)
.toggleClass('fa-chevron-up', isCollapsed);
}

function syncSectionCollapseWithVisibleItems($section, $items, $collapseToggle) {
const hasVisibleItems = getVisibleAnalysisItems($items).length > 0;

$collapseToggle.prop('disabled', !hasVisibleItems);
setSectionCollapsed($section, $collapseToggle, !hasVisibleItems);
Comment thread
jacobwillsmith marked this conversation as resolved.
}

function configureCollapseToggle($section, $collapseToggle) {
$collapseToggle
.off('click')
.on('click', function() {
const isCollapsed = $section.toggleClass('collapsed').hasClass('collapsed');
const $icon = $(this).find('i');

$(this)
.attr('aria-expanded', (!isCollapsed).toString())
.attr('title', isCollapsed ? labels.expandTitle : labels.collapseTitle);
if ($(this).prop('disabled')) {
return;
}

$icon
.toggleClass('fa-chevron-down', !isCollapsed)
.toggleClass('fa-chevron-up', isCollapsed);
const isCollapsed = $section.toggleClass('collapsed').hasClass('collapsed');
setSectionCollapsed($section, $(this), isCollapsed);
});
}

Expand Down Expand Up @@ -214,7 +236,7 @@ function appendSectionItems($items, section, isDismissedVisible) {
updateVisibleItemLayout($items);
}

function configureDismissedItemsToggle($items, $toggle, section, isDismissedVisible) {
function configureDismissedItemsToggle($section, $items, $toggle, $collapseToggle, section, isDismissedVisible) {
const labels = getAnalysisLabels();
const hiddenCount = section.hiddenItems.length;

Expand All @@ -239,6 +261,7 @@ function configureDismissedItemsToggle($items, $toggle, section, isDismissedVisi
dismissedSectionVisibility[section.itemType] = shouldShow;
$items.find('.dismissed-item').toggle(shouldShow);
updateVisibleItemLayout($items);
syncSectionCollapseWithVisibleItems($section, $items, $collapseToggle);
$toggle.text(shouldShow ? labels.hideDismissed : labels.showDismissed);
});
}
Expand All @@ -250,7 +273,6 @@ function renderSection(section) {

$section
.addClass(section.sectionClass)
.toggleClass('compact', section.activeItems.length === 0)
.toggleClass('header-only', !section.hasItems);
Comment thread
jacobwillsmith marked this conversation as resolved.

const $items = $section.find('[data-element="items"]');
Expand All @@ -264,7 +286,8 @@ function renderSection(section) {
$collapseToggle.toggle(section.hasItems);

appendSectionItems($items, section, isDismissedVisible);
configureDismissedItemsToggle($items, $toggle, section, isDismissedVisible);
configureDismissedItemsToggle($section, $items, $toggle, $collapseToggle, section, isDismissedVisible);
syncSectionCollapseWithVisibleItems($section, $items, $collapseToggle);

return $section;
}
Expand Down
Loading