fix: set default cancellation fields values when empty - #246
Merged
mdiapenabc merged 1 commit intoMay 13, 2026
Merged
Conversation
saifrazabc
approved these changes
May 13, 2026
saifrazabc
left a comment
saifrazabc
left a comment
Collaborator
There was a problem hiding this comment.
Approving for set default cancellation fields values when empty
mdiapenabc
merged commit May 13, 2026
c05f08f
into
release/cra-file-transfer-enabled
17 checks passed
mdiapenabc
added a commit
that referenced
this pull request
May 13, 2026
chore: set correctly default cancellation fields values (#246)
mdiapenabc
added a commit
that referenced
this pull request
May 14, 2026
mdiapenabc
added a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The system was not applying these defaults, so contacts with null
careEndDateorcancelReasonCodeshowed blank fields in Batch Details and Batch History.What Changes
addContactsToPendingBatch(): when transaction type is cancellation, defaultcareEndDateto system date andcancelReasonCodeto "21" if blank on the contact recordfindContactBatches(): returncancelReasonCodeandcancelReasonLabelin Batch History response (was missing; already present infindBatchContactsfor Batch Details)getCancelReasonLabel(): extract shared helper to eliminate duplicated cancel reason label lookup betweenfindBatchContactsandfindContactBatches