fix: add source_agreement for agreement details display - #384
Merged
Conversation
Introduce source_agreement so OOC contacts show ICM/MIS in Agreement Details while placement source stays scoped to primary placement. Includes migration backfill from source_placement, eligibility extract, API/frontend wiring, and tests for OOC and MIS agreement fallback paths.
saifrazabc
approved these changes
Jun 24, 2026
saifrazabc
left a comment
saifrazabc
left a comment
Collaborator
There was a problem hiding this comment.
Approve to ad source_agreement for agreement details display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
source_agreementso Agreement Details shows ICM/MIS from the primary agreement. Placement Details still usessource_placement. Fixes blank Agreement Source for OOC contacts (OPC/OPO/OPT) where placement is intentionally blank.What Changed
V22: addsource_agreement, backfill fromsource_placementprimaryAgreement?.source ?? primaryPlacement?.sourcesourceAgreement; Agreement Details Source uses itplacement_locationis blankHow To Test
cd backend && npm test -- src/sync/eligibility/eligibility.service.spec.tscd frontend && npm test -- src/utils/__tests__/mock-placement.test.ts