feat: added multiple fields to search bar of child search section in weekly file processing tab - #394
Merged
Conversation
mdiapenabc
requested changes
Jun 29, 2026
mdiapenabc
left a comment
Collaborator
There was a problem hiding this comment.
We should be using the existing contact search or amend it instead of creating search/wklcontact.
saifrazabc
approved these changes
Jun 29, 2026
saifrazabc
left a comment
Collaborator
There was a problem hiding this comment.
Approved for created new search api for weekly file processing
Contributor
Author
|
Neither of the existing api's (search/filter api) have the migrations for person id mis/icm and birth place. So I created a separate search api for the weekly file processing alone that filters person id mis/icm and birth place. On the UI, I'm invoking both the old search api and the new api and combing both the results. |
Weekly child search now uses getAllContacts with an OR filter on searchText (AKA-aware) plus person ID and birth place columns. Filter like values are escaped consistently with fullTextSearch.
mdiapenabc
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The weekly file child search now uses a two-path search approach instead of relying on the old single search call.
Scope stayed limited to the Weekly File Processing child search table. The Eligibility List search and filters were not changed.
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist
In Progress/Follow Up