feat: merge monitoring tab changes to test - #421
Merged
Merged
Conversation
* feat: add job monitoring API and wire frontend tab to backend Add job_runs summary/warning columns, job_activities table, monitoring read endpoints (latest, history, activities), and activity logging on job lifecycle. Update JobMonitoringTab to call the new API via jobs-service. Clean implementation on top of origin/dev — no release merge baggage. * feat(job-monitoring): Step 1 — APL-10 job list and monitoring foundations Wire latest-per-type job list to FDD: six monitored types, IDIR on user triggers, display formatters, and summaries derived from job metadata. Drop persisted summary/warning columns; consolidate V26 migration. * feat(job-monitoring): Step 2 — APL-11 job history query Include ICM/MIS child runs in history, filter by startedAt window, default sort startedAt DESC, and support IDIR filter on triggered_by_user. * feat(job-monitoring): Step 3 — FDD activity enums and instrumentation Add JobActivityService with FDD severity/type enums, remove lifecycle activity noise, record eligibility and ICM sync notices, and align Activities UI filters with APL-12. * feat(job-monitoring): Step 4 — job-scoped dual-write activity logging Wire AsyncLocalStorage job scope through JobRunner so curated Winston logs also persist to job_activities via AppLogger activity methods and aggregation. * feat(job-monitoring): Step 5 — admin gating, auto-refresh, handler instrumentation Gate the Monitoring tab to ICM CSA Application RW users, poll job tables while runs are active, and extend activity logging to auto-batch, send CRA, retry-failed, and sync-ICM handlers. * feat(job-monitoring): wire eligibility and WKL activity instrumentation Extend activity logging to eligibility skip paths and WKL matching services, and remove RW-only Monitoring tab gating until a role model is defined. * feat(job-monitoring): allow jobless activities and close instrumentation gaps Make job_activities.job_run_id nullable so standalone operator actions can be logged, persist curated activities without job scope, and wire remaining job-scoped gaps (parse failures, stuck jobs, auto-batch validation, ingest). * feat(job-monitoring): Phase 5.1 logging convention and manual op activities Unify AppLogger on tagged warn/error/crit dual-write, log manual eligibility and batch issues to Activities, and demote mocks/config noise to log while keeping integration data-quality warns in Splunk. * docs(job-monitoring): move impl plan to documentation and fold V27 into V26 Relocate the implementation plan out of docs/functional-design, trim ADR 0012 to the standard template, and create job_activities with nullable job_run_id in V26 only. * chore: keep documentation and docs README out of the repo Remove docs/README.md and untrack documentation/; add documentation/ to .gitignore and drop broken ADR links to local-only docs. * revert: restore ADR 0012 to pre-job-monitoring version Decision doc updates will be amended separately later. * chore: drop documentation/ from .gitignore Local documentation stays excluded via .git/info/exclude per clone. * fixed the lint fail issues * updated the column filters * fixed sorting accross tables of job monitoring tab --------- Co-authored-by: plakkara <preethi.lakkaraju@gov.bc.ca>
kayboy-007
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add job_runs summary/warning columns, job_activities table, monitoring read endpoints (latest, history, activities), and activity logging on job lifecycle. Update JobMonitoringTab to call the new API via jobs-service.
Clean implementation on top of origin/dev — no release merge baggage.
Wire latest-per-type job list to FDD: six monitored types, IDIR on user triggers, display formatters, and summaries derived from job metadata. Drop persisted summary/warning columns; consolidate V26 migration.
Include ICM/MIS child runs in history, filter by startedAt window, default sort startedAt DESC, and support IDIR filter on triggered_by_user.
Add JobActivityService with FDD severity/type enums, remove lifecycle activity noise, record eligibility and ICM sync notices, and align Activities UI filters with APL-12.
Wire AsyncLocalStorage job scope through JobRunner so curated Winston logs also persist to job_activities via AppLogger activity methods and aggregation.
Gate the Monitoring tab to ICM CSA Application RW users, poll job tables while runs are active, and extend activity logging to auto-batch, send CRA, retry-failed, and sync-ICM handlers.
Extend activity logging to eligibility skip paths and WKL matching services, and remove RW-only Monitoring tab gating until a role model is defined.
Make job_activities.job_run_id nullable so standalone operator actions can be logged, persist curated activities without job scope, and wire remaining job-scoped gaps (parse failures, stuck jobs, auto-batch validation, ingest).
Unify AppLogger on tagged warn/error/crit dual-write, log manual eligibility and batch issues to Activities, and demote mocks/config noise to log while keeping integration data-quality warns in Splunk.
Relocate the implementation plan out of docs/functional-design, trim ADR 0012 to the standard template, and create job_activities with nullable job_run_id in V26 only.
Remove docs/README.md and untrack documentation/; add documentation/ to .gitignore and drop broken ADR links to local-only docs.
Decision doc updates will be amended separately later.
Local documentation stays excluded via .git/info/exclude per clone.
fixed the lint fail issues
updated the column filters
fixed sorting accross tables of job monitoring tab
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist
In Progress/Follow Up