fix: report auto-batch on-hold totals in completion summary - #444
Merged
Conversation
Surface excluded record counts and missing-field details after Add System determined Eligible/NE kids to Batch, sync ICM when only auto-hold occurs, and refresh the contacts list when incomplete records are placed on hold.
plakkara-bc
self-requested a review
August 7, 2026 19:07
plakkara-bc
approved these changes
Aug 7, 2026
plakkara-bc
self-requested a review
August 7, 2026 19:28
mdiapenabc
marked this pull request as ready for review
August 7, 2026 19:39
plakkara-bc
approved these changes
Aug 7, 2026
Unblocks CI lint on PR #444 after FDD feedback for Add All on-hold totals.
Use existing BatchesService log wording for the on-hold suffix, keep manual incomplete dialog unchanged, and drop the auto-batch summary dialog. Preserve prior snackbar severity, refresh, and ICM sync-back conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add System determined Eligible/NE kids to Batch flow to notify users how many records were added and how many were excluded due to missing CRA mandatory fields (auto-placed On Hold). Auto-batch already skipped incomplete records and put them On Hold, but the completion message only reported application/cancellation counts added to the batch.
This change surfaces the on-hold total in the job result, UI snackbar, Job Monitoring summary, and a read-only dialog listing excluded records and their missing fields.
What changed
AutoBatchResultwithonHoldcount andincompleterecord list fromBatchesServiceIncompleteRecordsDialog(read-only summary; records already on hold)How to test
4 application, 2 cancellation contacts added to batch; 3 placed on hold due to missing CRA mandatory fields)