Skip to content

fix: report auto-batch on-hold totals in completion summary - #444

Merged
mdiapenabc merged 4 commits into
devfrom
fix/auto-batch-on-hold-summary
Aug 7, 2026
Merged

fix: report auto-batch on-hold totals in completion summary#444
mdiapenabc merged 4 commits into
devfrom
fix/auto-batch-on-hold-summary

Conversation

@mdiapenabc

@mdiapenabc mdiapenabc commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Add System determined Eligible/NE kids to Batch flow to notify users how many records were added and how many were excluded due to missing CRA mandatory fields (auto-placed On Hold). Auto-batch already skipped incomplete records and put them On Hold, but the completion message only reported application/cancellation counts added to the batch.

This change surfaces the on-hold total in the job result, UI snackbar, Job Monitoring summary, and a read-only dialog listing excluded records and their missing fields.

What changed

  • Extended AutoBatchResult with onHold count and incomplete record list from BatchesService
  • Added shared completion summary formatting for auto-batch job message and logs
  • Updated Job Monitoring AUTO_BATCH summary to include on-hold count when present
  • Trigger ICM sync-back when records are only auto-held (no batch adds)
  • Updated frontend auto-batch completion snackbar to report added and on-hold totals
  • Added auto-batch variant of IncompleteRecordsDialog (read-only summary; records already on hold)
  • Refresh contacts list when records are placed on hold, even if none were added to batch

How to test

  • Run Add System determined Eligible/NE kids to Batch with a mix of complete and incomplete records
  • Confirm snackbar reports both added counts and placed on hold count (e.g. 4 application, 2 cancellation contacts added to batch; 3 placed on hold due to missing CRA mandatory fields)
  • Confirm Records Placed On Hold dialog opens with contact IDs and missing fields
  • Confirm excluded records show On Hold status with hold reason in audit trail
  • Run auto-batch where all candidates are incomplete; confirm on-hold-only summary and contacts list refresh
  • Check Job Monitoring AUTO_BATCH row summary includes on-hold count when applicable
  • Confirm manual Add selected items to batch flow is unchanged (confirm dialog still offers OK/Cancel to put on hold)

Surface excluded record counts and missing-field details after Add System
determined Eligible/NE kids to Batch, sync ICM when only auto-hold occurs,
and refresh the contacts list when incomplete records are placed on hold.
@plakkara-bc
plakkara-bc self-requested a review August 7, 2026 19:07
@plakkara-bc
plakkara-bc self-requested a review August 7, 2026 19:28
@mdiapenabc
mdiapenabc marked this pull request as ready for review August 7, 2026 19:39
plakkara-bc and others added 3 commits August 7, 2026 15:46
Unblocks CI lint on PR #444 after FDD feedback for Add All on-hold totals.
Use existing BatchesService log wording for the on-hold suffix, keep manual
incomplete dialog unchanged, and drop the auto-batch summary dialog.
Preserve prior snackbar severity, refresh, and ICM sync-back conditions.
@mdiapenabc
mdiapenabc merged commit 9ac11c7 into dev Aug 7, 2026
20 checks passed
@mdiapenabc
mdiapenabc deleted the fix/auto-batch-on-hold-summary branch August 7, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants