Menu: fix TypeScript error

[mkernohanbc]

This PR fixes a TypeScript error in the Menu component. Previously, there was an inconsistency in how the items prop (used to pass an array of menu items) was typed in the MenuSectionProps and MenuProps interfaces. In MenuProps it was typed as items?: T[], which caused an incompatibility error with the onAction callback.

With this change, items is now typed consistently as items: MenuItemProps[] in both contexts. This resolves the error, and is consistent with how we've approached this same functionality in Select.

[Copilot]

Pull request overview

This PR updates the Menu component’s TypeScript types to resolve an incompatibility stemming from inconsistent items typing between MenuSectionProps and MenuProps, aligning MenuProps.items to use MenuItemProps[].

Changes:

• Remove the generic type parameter from MenuProps and the Menu component signature.
• Type MenuProps as ReactAriaMenuProps<MenuItemProps> and items?: MenuItemProps[] to match MenuSectionProps.items.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ty2k]

Good change, I think it's better to avoid the generic <T>.

On the itemsprop, I see right now it's required for MenuSectionProps but optional for MenuProps. If that's by design, can we add a comment to explain why? If it's not, can we use the same behaviour in both places?

[mkernohanbc]

Good change, I think it's better to avoid the generic <T>.

On the itemsprop, I see right now it's required for MenuSectionProps but optional for MenuProps. If that's by design, can we add a comment to explain why? If it's not, can we use the same behaviour in both places?

Good spot — this was matching the structure from Select (where items is the only way to compose within sections), but doesn't fit the design here (where we're also exporting MenuSection and MenuItem to support another way to compose.)

6906096 makes items optional.

[ty2k]

👍 👍