APS-3732 Path-level validation for sdx related routes - #262
Merged
Conversation
- implemented validation methods and unit tests - added validation check to endpoints
phowells
force-pushed
the
feature/sdx-path-level-validation
branch
from
April 1, 2026 20:00
a13cc9e to
d2d8bc8
Compare
|
🔔 Friendly reminder: The following reviewers still need to review this PR: @ikethecoder PS: @sdqdadat |
ikethecoder
requested changes
Apr 10, 2026
| elif do_validate_upstreams and (host in perm_upstreams) is False: | ||
| errors.append("service upstream is invalid (e6)") | ||
|
|
||
| def validate_route_paths(yaml, ns_attributes, do_validate_route_paths: bool = False): |
Member
There was a problem hiding this comment.
Looks like validate_route_paths function is defined twice?
Contributor
Author
There was a problem hiding this comment.
Cut and paste error. Removed.
|
rustyjux
approved these changes
Apr 13, 2026
ikethecoder
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add path-level validation to the gwa-api so that there is path exclusivity for a gateway to support the service paths.
Implemented validation methods and unit tests
Added validation check to v1 and v2 publish endpoints
Types of changes
Checklist
Further comments