32928 add validation to short form amalgamations to reject nr name when supplied#4442
Merged
Conversation
|
kialj876
approved these changes
May 28, 2026
Collaborator
kialj876
left a comment
kialj876
left a comment
There was a problem hiding this comment.
Nice work, looks good to me. Please wait for Megan's review as well before merging
meawong
approved these changes
May 28, 2026
Collaborator
meawong
left a comment
meawong
left a comment
There was a problem hiding this comment.
Nice! Sorry again for the confusion on this ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32928
Description of changes:
Backend now rejects nrNumber on short-form (horizontal/vertical) amalgamations
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).