#34016 fix: Enable magnifying glass search in BusinessLookup for authenticated users - #877
Merged
Merged
Conversation
Release: promote Solr changes to main for TEST deployment
When authenticated (IDIR/BCeID/BCSC), the BusinessLookup component is used instead of BusinessFetch. While BusinessFetch had the magnifying glass wired to trigger search, BusinessLookup did not. This made the icon appear non-functional for all authenticated users in both DEV and TEST environments. Changes: - Wire @click:append event to call onMagnifyClick() handler - Add async onMagnifyClick() method that performs immediate (non-debounced) search - Validates minimum 3 characters before executing search - Reuses existing BusinessLookupServices.search() with proper auth headers The immediate search (no 600ms debounce) provides better UX when using the magnifying glass, while the character validation ensures safe searches. Works for all authentication methods (IDIR, BCeID, BCSC) via shared Keycloak interceptors and axios auth headers.
…ed users Fixed magnifying glass icon functionality when using BusinessLookup component (used for authenticated users). The icon was previously non-functional due to v-model binding issues and #append slot conflicts. Changes: - Fixed Vue 2 compatibility: Changed v-model:search-input to :search-input.sync - Moved magnifying glass icon from append-icon prop to explicit v-icon in slot - Added click handler with proper event binding (.stop to prevent propagation) - Added CSS styling to make icon cursor:pointer and interactive - Implemented dual-mode search: business numbers (BC1234567) and company names (3+ chars) - Added input validation with user-friendly error messages - Both debounced input (600ms) and immediate magnifying glass click work now - Case-insensitive: Accepts lowercase, converts to uppercase for API The magnifying glass now provides immediate search (no debounce) while the input field uses 600ms debounce for auto-search as user types.
Oluwapizzy
requested review from
davemck513,
mengdong19,
ozamani9gh and
stevenc987
as code owners
June 30, 2026 02:35
Oluwapizzy
changed the title
stevenc987
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bcgov/entity#34016
Fixed magnifying glass icon functionality when using BusinessLookup component (used for authenticated users). The icon was previously non-functional due to v-model binding issues and #append slot conflicts.
Changes: