Skip to content

Fix issue #4454#5342

Merged
narfbg merged 3 commits into
bcit-ci:developfrom
aanbar:pagination-bc-fix
Nov 28, 2017
Merged

Fix issue #4454#5342
narfbg merged 3 commits into
bcit-ci:developfrom
aanbar:pagination-bc-fix

Conversation

@aanbar

@aanbar aanbar commented Nov 26, 2017

Copy link
Copy Markdown
Contributor

@narfbg I ran into a similar issue, Looking into the diff you provided
#4454 (comment)

I found out that it was actually being reset, As you have to call the initialize method again to give it the urls ...etc

@narfbg

narfbg commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

Nothing in the documentation implies that you can combine config files with additional initialize() calls without resets. That being said, I don't mind this, but you have to find a way to make it work together with #4000 (the patch for that issue causes this one).

P.S.: I find it funny that you've named the branch "pagination-bc-fix"; 12 version later this is anything but a BC fix. :D

@aanbar

aanbar commented Nov 27, 2017

Copy link
Copy Markdown
Contributor Author

@narfbg
I've never added a class to my pagination links before, that's why I did not notice the difference until now; blame it on bootstrap 4 maybe? :D.
And I don't think that anything related to styling should be reset unless you explicitly want to reset it

I have updated the file to account for the rel attribute

@narfbg narfbg added this to the 3.1.7 milestone Nov 28, 2017
@narfbg
narfbg merged commit c19cce9 into bcit-ci:develop Nov 28, 2017
narfbg added a commit that referenced this pull request Nov 28, 2017
narfbg added a commit that referenced this pull request Nov 28, 2017
Preserve attributes from pagination config files

Related: #4454
narfbg added a commit that referenced this pull request Nov 28, 2017
narfbg added a commit that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants