Fix issue #4454#5342
Merged
Merged
Conversation
Contributor
|
Nothing in the documentation implies that you can combine config files with additional P.S.: I find it funny that you've named the branch "pagination-bc-fix"; 12 version later this is anything but a BC fix. :D |
Contributor
Author
|
@narfbg I have updated the file to account for the rel attribute |
narfbg
added a commit
that referenced
this pull request
Nov 28, 2017
narfbg
added a commit
that referenced
this pull request
Nov 28, 2017
Preserve attributes from pagination config files Related: #4454
narfbg
added a commit
that referenced
this pull request
Nov 28, 2017
narfbg
added a commit
that referenced
this pull request
Nov 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@narfbg I ran into a similar issue, Looking into the diff you provided
#4454 (comment)
I found out that it was actually being reset, As you have to call the initialize method again to give it the urls ...etc