Conversation
| All files | 91.67 | 100 | 80 | 91.67 | | | ||
| normal.js | 85.71 | 100 | 50 | 85.71 | 14,15,16 | | ||
| timeout.js | 100 | 100 | 100 | 100 | | | ||
| ------------|----------|----------|----------|----------|----------------|`) |
There was a problem hiding this comment.
Are these changes expected?
There was a problem hiding this comment.
I had these results even without updating the dependencies, so I assumed that the change was caused by simply having a more recent version of Node.
By looking into it deeper, you are right that it reveals an issue. The functions in fixtures/normal are counted as 0/1 instead of 1/2. The apple function is not detected as a function.
I should probably revert the change for this file: the tests were already failing before updating the dependencies and there's no CI anyway. What do you think?
|
I isolated the example in a minimal setting. I currently get odd coverage results (not all the functions are matched) that may be related to the changes here. I need to check if there's an issue with the way I test it or if it's a Node/V8 issue. |
|
Ok, I managed to get the right order of invocations to get V8 to return the coverage for Edit: V8 results: https://gist.github.com/demurgos/deb05f530f9f9f8e2542e7284df9de8f |
|
My refactored Remaining work:
|
2 participants
This commit updates the dependencies to their latest version.
The only difference is a different expected output for the integration tests.