Skip to content

Fix offline example TypeScript config paths - #301

Merged
bcomnes merged 2 commits into
masterfrom
bret/fix-offline-example-tsconfig
Sep 6, 2026
Merged

Fix offline example TypeScript config paths#301
bcomnes merged 2 commits into
masterfrom
bret/fix-offline-example-tsconfig

Conversation

@bcomnes

@bcomnes bcomnes commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Point both offline examples at the repository root TypeScript configuration.
  • Keep the change limited to the two configuration paths.

Validation

  • npm test and npm run build-examples passed before the review-only test removal.
  • After removing the extra test, npm run test:neostandard passed and tsc --showConfig successfully resolved both offline example configurations.

Fixes #292.

@coveralls

coveralls commented Sep 6, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 34012037263

Coverage increased (+0.5%) to 94.677%

Details

  • Coverage increased (+0.5%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 7306
Covered Lines: 7080
Line Coverage: 96.91%
Relevant Branches: 1505
Covered Branches: 1262
Branch Coverage: 83.85%
Branches in Coverage %: Yes
Coverage Strength: 178.69 hits per line

💛 - Coveralls

Comment thread examples/tsconfig.test.js Outdated
@bcomnes
bcomnes marked this pull request as ready for review September 6, 2026 04:37
@bcomnes
bcomnes merged commit 78949d3 into master Sep 6, 2026
10 checks passed
@bcomnes
bcomnes deleted the bret/fix-offline-example-tsconfig branch September 6, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Offline examples extend a nonexistent TypeScript config

2 participants