I2SO bug when using as Spindle Enable signal

[robercy]

Hello !
When using I2So outputs to enable Spindles, other I2SO outputs flash randomly, it causes too many undue step pulses, and erratic axes movements. I use TMC2209 as drivers, and UART to control.

To solve this problem I commented the line below (line 70), in the PWMSpindle.cpp file, and I stopped having this problem.

void IRAM_ATTR PWM::setSpeedfromISR(uint32_t dev_speed) {
    // set_enable(gc_state.modal.spindle != SpindleState::Disable);
    set_output(dev_speed);
}

I’m using firmware 3.3.2, and I could repeat the problem changing enable pins from I2SO to gpio pins, on Spindle configuration. Maybe, to solve the problem, calling set_enable just when signal change, could resolve.

It seems that a refresh rate, when used as an output for the Spindle, is too high, not giving the 74HC595 time to operate properly.

This is my configuration:

board: Roby CNC
name: Roby CNC Multibot V2

arc_tolerance_mm: 0.002
junction_deviation_mm: 0.010
verbose_errors: false
report_inches: false
enable_parking_override_control: false
use_line_numbers: false

stepping:
engine: I2S_STREAM
idle_ms: 250
pulse_us: 4
dir_delay_us: 1
disable_delay_us: 0

axes:
shared_stepper_disable_pin: NO_PIN

x:
steps_per_mm: 400.0
max_rate_mm_per_min: 1200.0
acceleration_mm_per_sec2: 100.0
max_travel_mm: 350.0
soft_limits: true
homing:
cycle: 2
positive_direction: true
mpos_mm: 1
feed_mm_per_min: 100.0
seek_mm_per_min: 200.0
settle_ms: 500
seek_scaler: 1.100
feed_scaler: 1.100

motor0:
  limit_neg_pin: gpio.36
  limit_pos_pin: gpio.39
  hard_limits: true
  pulloff_mm: 1.000
  tmc_2209:
    uart:
      rxd_pin: gpio.18
      txd_pin: gpio.19
      baud: 115200
      mode: 8N1
    addr: 0
    r_sense_ohms: 0.110
    run_amps: 1.200
    hold_amps: 0.100
    microsteps: 16
    stallguard: 30
    stallguard_debug: false
    toff_disable: 0
    toff_stealthchop: 5
    toff_coolstep: 3
    run_mode: StealthChop
    homing_mode: StealthChop
    use_enable: true
    disable_pin: I2SO.0
    direction_pin: I2SO.1
    step_pin: I2SO.2

y:
steps_per_mm: 400.0
max_rate_mm_per_min: 1200.0
acceleration_mm_per_sec2: 100.0
max_travel_mm: 450.0
soft_limits: true
homing:
cycle: 2
positive_direction: true
mpos_mm: 1
feed_mm_per_min: 100.0
seek_mm_per_min: 200.0
settle_ms: 500
seek_scaler: 1.100
feed_scaler: 1.100

motor0:
  limit_neg_pin: gpio.34
  limit_pos_pin: gpio.35
  hard_limits: true
  pulloff_mm: 1.000
  tmc_2209:
    addr: 1
    r_sense_ohms: 0.110
    run_amps: 1.200
    hold_amps: 0.100
    microsteps: 16
    stallguard: 30
    stallguard_debug: false
    toff_disable: 0
    toff_stealthchop: 5
    toff_coolstep: 3
    run_mode: StealthChop
    homing_mode: StealthChop
    use_enable: true
    disable_pin: I2SO.4
    direction_pin: I2SO.5
    step_pin: I2SO.6
motor1:
  limit_neg_pin: gpio.32
  limit_pos_pin: gpio.33
  hard_limits: true
  pulloff_mm: 1.000
  tmc_2209:
    addr: 2
    r_sense_ohms: 0.110
    run_amps: 1.200
    hold_amps: 0.100
    microsteps: 16
    stallguard: 30
    stallguard_debug: false
    toff_disable: 0
    toff_stealthchop: 5
    toff_coolstep: 3
    run_mode: StealthChop
    homing_mode: StealthChop
    use_enable: true
    disable_pin: I2SO.8
    direction_pin: I2SO.9
    step_pin: I2SO.10

z:
steps_per_mm: 400.0
max_rate_mm_per_min: 1000.0
acceleration_mm_per_sec2: 100.0
max_travel_mm: 60.0
soft_limits: true
homing:
cycle: 1
positive_direction: true
mpos_mm: 1
feed_mm_per_min: 100.0
seek_mm_per_min: 200.0
settle_ms: 500
seek_scaler: 1.100
feed_scaler: 1.100

motor0:
  limit_neg_pin: gpio.25
  limit_pos_pin: gpio.26
  hard_limits: true
  pulloff_mm: 1.000
  tmc_2209:
    addr: 3
    r_sense_ohms: 0.110
    run_amps: 1.200
    hold_amps: 0.100
    microsteps: 16
    stallguard: 30
    stallguard_debug: false
    toff_disable: 0
    toff_stealthchop: 5
    toff_coolstep: 3
    run_mode: StealthChop
    homing_mode: StealthChop
    use_enable: true
    disable_pin: I2SO.12
    direction_pin: I2SO.13
    step_pin: I2SO.14

PWM:
pwm_hz: 5000
output_pin: gpio.23
enable_pin: I2SO.16
direction_pin: I2SO.17
disable_with_s0: false
s0_with_disable: true
spinup_ms: 0
spindown_ms: 0
tool_num: 0
speed_map: 0=0% 9000=100%

Laser:
pwm_hz: 5000
output_pin: gpio.15
enable_pin: I2SO.18
disable_with_s0: false
s0_with_disable: true
tool_num: 10
speed_map: 0=0.000% 255=100.000%

Relay:
output_pin: I2SO.19

coolant:
flood_pin: I2SO.20
mist_pin: I2SO.21
delay_ms: 0

i2so:
bck_pin: gpio.22
data_pin: gpio.21
ws_pin: gpio.17

probe:
pin: gpio.27:low:pu
check_mode_start: true

Regards,
Robercy

[Eric-ERGS]

I can confirm robercy issue, Setting up a new Dring 6 Pack external CNC controller board with a 4 port 5v output module I noticed that the outputs were flicking when I moved a axis and if I changed my relay: configuration from using ISO outputs to GPIO the problem went away.

I have not tried to make the code modification yet.

Config File:

board: 6 Pack
name: 6 Pack external XYYZAB
stepping:
engine: I2S_STREAM
idle_ms: 100
pulse_us: 4
dir_delay_us: 1000
disable_delay_us: 0

axes:
shared_stepper_disable_pin: gpio.25:low
x:
steps_per_mm: 568.7203
max_rate_mm_per_min: 5000.000
acceleration_mm_per_sec2: 5.000
max_travel_mm: 360.000
soft_limits: true
homing:
cycle: 2
positive_direction: false
mpos_mm: -10.00
feed_mm_per_min: 100.000
seek_mm_per_min: 800.000
settle_ms: 750
seek_scaler: 1.100
feed_scaler: 1.100

motor0:
  limit_neg_pin: NO_PIN
  limit_pos_pin: gpio.34:high
  limit_all_pin: NO_PIN
  hard_limits: false
  pulloff_mm: 1.000
  standard_stepper:
    step_pin: I2SO.2
    direction_pin: I2SO.1
    disable_pin: I2SO.0

y:
steps_per_mm: 568.7203
max_rate_mm_per_min: 5000.000
acceleration_mm_per_sec2: 5.000
max_travel_mm: 270.000
soft_limits: true
homing:
cycle: 2
positive_direction: true
mpos_mm: 10.000
feed_mm_per_min: 100.000
seek_mm_per_min: 200.000
settle_ms: 750
seek_scaler: 1.100
feed_scaler: 1.100

motor0:
  limit_neg_pin: NO_PIN
  limit_pos_pin: gpio.35:high
  limit_all_pin: NO_PIN
  hard_limits: false
  pulloff_mm: 1.000
  standard_stepper:
    step_pin: I2SO.5
    direction_pin: I2SO.4
    disable_pin: I2SO.7
motor1:
  limit_neg_pin: NO_PIN
  limit_pos_pin: gpio.32:high
  limit_all_pin: NO_PIN
  hard_limits: false
  pulloff_mm: 1.000
  standard_stepper:
    step_pin: I2SO.10
    direction_pin: I2SO.9
    disable_pin: I2SO.8

z:
steps_per_mm: 568.7203
max_rate_mm_per_min: 5000.000
acceleration_mm_per_sec2: 5.000
max_travel_mm: 70.000
soft_limits: true
homing:
cycle: 1
positive_direction: true
mpos_mm: 35.000
feed_mm_per_min: 100.000
seek_mm_per_min: 800.000
settle_ms: 750
seek_scaler: 1.100
feed_scaler: 1.100

motor0:
  limit_neg_pin: NO_PIN
  limit_pos_pin: gpio.33:high
  limit_all_pin: NO_PIN
  hard_limits: false
  pulloff_mm: 1.000
  standard_stepper:
    step_pin: I2SO.13
    direction_pin: I2SO.12
    disable_pin: I2SO.15

i2so:
bck_pin: gpio.22
data_pin: gpio.21
ws_pin: gpio.17

spi:
miso_pin: gpio.19
mosi_pin: gpio.23
sck_pin: gpio.18

sdcard:
card_detect_pin: NO_PIN
cs_pin: gpio.5

coolant:
flood_pin: NO_PIN
mist_pin: NO_PIN
delay_ms: 0

probe:
pin: gpio.39
check_mode_start: true

user_outputs:
analog0_pin: NO_PIN
analog1_pin: NO_PIN
analog2_pin: NO_PIN
analog3_pin: NO_PIN
analog0_hz: 5000
analog1_hz: 5000
analog2_hz: 5000
analog3_hz: 5000
digital0_pin: gpio.14
digital1_pin: gpio.13
digital2_pin: I2SO.25
digital3_pin: I2SO.24

start:
must_home: false

relay:
direction_pin: NO_PIN
output_pin: GPIO.2 ##### If this is changed to a ISO.27, ISO.24 and ISO.25 Flicker
enable_pin: NO_PIN
disable_with_s0: false
s0_with_disable: true
spinup_ms: 0
spindown_ms: 0
tool_num: 0
speed_map: 0=0.000% 0=100.000% 1=100.000%

relay:
direction_pin: NO_PIN
output_pin: gpio.4 ##### If this is changed to a ISO.26, ISO.24 and ISO.25 Flicker
enable_pin: NO_PIN
disable_with_s0: false
s0_with_disable: true
spinup_ms: 0
spindown_ms: 0
tool_num: 100
speed_map: 0=0.000% 0=100.000% 1=100.000%

Thanks,
Eric.

[MitchBradley]

Try I2S_STATIC mode and see if the problem still occurs in that mode.

[Eric-ERGS]

Mitch, I sould have mentioned that I tried that before noticing this bug report and going to static had no effect the outputs still flickered. Thanks, Eric.

…

On Sat., Oct. 8, 2022, 12:40 p.m. Mitch Bradley, ***@***.***> wrote: Try I2S_STATIC mode and see if the problem still occurs in that mode. — Reply to this email directly, view it on GitHub <#287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZ6HUCY5XQBCLFIIQE4YMDLWCGPYDANCNFSM5N6TIOKA> . You are receiving this because you commented.Message ID: ***@***.***>

[robercy]

Hello, Eric and Mitch.
Nice to hear , that this problem have a solution. Tomorow I will try it.

Keep the good work, fellows.

Greetings.

[robercy]

Hi Mitch,

Version 3.6.3 tested on my setup, with I2S_STREAM, and it's working now. Congratulations!

Have a nice day, and Thanks.