fix: prevent containers from sticking during shutdown - #1826
Merged
Conversation
mernit
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes containers sticking during shutdown by reliably cancelling startup when a stop is issued and recovering from wedged workspace mounts (GeeseFS) after SIGKILL.
Bug Fixes
containercancels; cancel startup contexts on stop events and after worker reconnects.cancelContainerIfAlreadyStoppingchecks local lifecycle state first, then repository with a 2s timeout.abortStuckWorkspaceMountunmounts GeeseFS workspaces after SIGKILL timeout even if no runtime existed, without impacting other containers.cancelBuild→cancelContainerin lifecycle handling; improved logging and tests for race and mount recovery.Dependencies
github.com/beam-cloud/geesefsreplacement to a newer commit.Written for commit 496180a. Summary will update on new commits.