Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Add Descriptive Deprecations#386

Merged
jeremylow merged 4 commits intomasterfrom
feature/UpdateBackgroundImage_deprecation
Sep 16, 2016
Merged

Add Descriptive Deprecations#386
jeremylow merged 4 commits intomasterfrom
feature/UpdateBackgroundImage_deprecation

Conversation

@jeremylow
Copy link
Copy Markdown
Collaborator

@jeremylow jeremylow commented Sep 16, 2016

Description

Adds a couple things:

  • PythonTwitterDeprecation warnings have been added to twitter/error.py. This is in the same vein as Django's warning release system where a deprecation warning is added prior to a release and has the release number included in the warning. So, for example, in version 3.2, there are a bunch of PythonTwitterDeprecation330 warnings letting you know what's going away in the next version.
  • In that spirit, the previous deprecation warnings have been converted to PythonTwitterDeprecation330 warnings where appropriate.
  • UpdateBackgroundImage now has a PythonTwitterDeprecation330 deprecation warning.

Related Issue

#341

How Has This Been Tested?

Unit tests added for deprecation of UpdateBackgroundImage. All new and old tests pass.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change is Reviewable

@codecov-io
Copy link
Copy Markdown

Current coverage is 74.27% (diff: 100%)

Merging #386 into master will increase coverage by 0.60%

@@             master       #386   diff @@
==========================================
  Files             8          8          
  Lines          1964       1971     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1447       1464    +17   
+ Misses          517        507    -10   
  Partials          0          0          

Powered by Codecov. Last update 3f99eaf...98a943f

@bear
Copy link
Copy Markdown
Owner

bear commented Sep 16, 2016

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jeremylow jeremylow merged commit 7126f2b into master Sep 16, 2016
@jeremylow jeremylow deleted the feature/UpdateBackgroundImage_deprecation branch September 16, 2016 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants