This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Merged
Conversation
Current coverage is 74.27% (diff: 100%)@@ master #386 diff @@
==========================================
Files 8 8
Lines 1964 1971 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1447 1464 +17
+ Misses 517 507 -10
Partials 0 0
|
Owner
|
Reviewed 5 of 5 files at r1. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a couple things:
twitter/error.py. This is in the same vein as Django's warning release system where a deprecation warning is added prior to a release and has the release number included in the warning. So, for example, in version 3.2, there are a bunch of PythonTwitterDeprecation330 warnings letting you know what's going away in the next version.Related Issue
#341
How Has This Been Tested?
Unit tests added for deprecation of UpdateBackgroundImage. All new and old tests pass.
Types of changes
Checklist:
This change is