This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Merged
Conversation
This is basically just a distillation of what is on twitter documentation, but consdensed so it is easier to read/reference when building out the changes.
Some of the URLs acknowledged by Twitter are not counted, most are. Some that Twitter says are not URLs, count as URLs. It is not perfect, but it covers a number of use cases. See tests/test_url_regex.py - the commented out URLs are the edge cases that are not addressed.
Collaborator
Author
|
@bear any thoughts? |
Owner
|
Reviewed 24 of 24 files at r1. Comments from Reviewable |
Owner
|
I am loving all the tests and changes - apologies for not looking at this soo much sooner |
Collaborator
Author
|
Awesome! Yeah - I think the changes to the tests will make it a whole lot easier to maintain going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes update the API to be compliant with the REST portions of the changes described here: https://dev.twitter.com/overview/api/upcoming-changes-to-tweets . There is a new
tweet_modeparameter for choosing whether to remain in compatibility mode (i.e., the old mode, but tweets may be truncated) or in the new, shinyextended_mode. Documentation has been updated, though it's a little rough at the moment while we see how things shake out from Twitter.Additionally, I fixed the regex a little bit for the URL parsing to better match that of Twitter. It's not perfect; see 0180e27 for details.
This is not a breaking change.
Related Issue
Issue #338
Issue #346
Motivation and Context
Changes are required for new
extended_modeHow Has This Been Tested?
Most tests had to be rewritten for the updates, as a new query parameter (
tweet_mode) is getting passed to Twitter with most of the GET requests. Changes have been tested, though I'd like to see better coverage for what's changed to make sure we're not missing something.Types of changes
Checklist:
This change is