This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Conversation
Adds `video_info` parameter to the construction of a Media object with addresses issue #387.
Current coverage is 74.83% (diff: 100%)@@ develop #398 diff @@
==========================================
Files 8 8
Lines 1943 1943
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1454 1454
Misses 489 489
Partials 0 0
|
Owner
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
video_infoparameter to the construction of a Media object addresses issue #387. This allows for the creation of avideo_infodicton theMediaobject, which was missing previously and prevented accessing video urls/bitrates/etc. from theextended_entitiesnode.Interestingly, this is probably going to be a little broken anyway - see: https://twitter.com/__jcbl__/status/793182389702975488 for discussion of truncation of tweets in
compatmode. Apparently, Twitter's not returning a media node if the media is in the truncated portion of the tweet.Doesn't address discussion around
include_entities. I'm disinclined to address that generally as changing the way it works would break existing functionality and break with Twitter's documented behavior.Related Issue
#387
How Has This Been Tested?
Tests have been added for the inclusion of
video_infoparam and all current tests pass.Types of changes
Checklist:
This change is