Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Add video_info param to Media class#398

Merged
jeremylow merged 2 commits intodevelopfrom
fix/issue387
Nov 1, 2016
Merged

Add video_info param to Media class#398
jeremylow merged 2 commits intodevelopfrom
fix/issue387

Conversation

@jeremylow
Copy link
Copy Markdown
Collaborator

@jeremylow jeremylow commented Oct 31, 2016

Description

Adds video_info parameter to the construction of a Media object addresses issue #387. This allows for the creation of a video_info dict on the Media object, which was missing previously and prevented accessing video urls/bitrates/etc. from the extended_entities node.

Interestingly, this is probably going to be a little broken anyway - see: https://twitter.com/__jcbl__/status/793182389702975488 for discussion of truncation of tweets in compat mode. Apparently, Twitter's not returning a media node if the media is in the truncated portion of the tweet.

Doesn't address discussion around include_entities. I'm disinclined to address that generally as changing the way it works would break existing functionality and break with Twitter's documented behavior.

Related Issue

#387

How Has This Been Tested?

Tests have been added for the inclusion of video_info param and all current tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change is Reviewable

Adds `video_info` parameter to the construction of a Media object
with addresses issue #387.
@codecov-io
Copy link
Copy Markdown

Current coverage is 74.83% (diff: 100%)

Merging #398 into develop will not change coverage

@@            develop       #398   diff @@
==========================================
  Files             8          8          
  Lines          1943       1943          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1454       1454          
  Misses          489        489          
  Partials          0          0          

Powered by Codecov. Last update 01b3ceb...e5be25e

@bear
Copy link
Copy Markdown
Owner

bear commented Oct 31, 2016

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jeremylow jeremylow merged commit c3a1107 into develop Nov 1, 2016
@jeremylow jeremylow deleted the fix/issue387 branch November 1, 2016 00:33
@jeremylow jeremylow mentioned this pull request Nov 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants