This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Fix warnings always being displayed at library level#440
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 74.84% 74.83% -0.02%
==========================================
Files 8 8
Lines 1944 1943 -1
==========================================
- Hits 1455 1454 -1
Misses 489 489
Continue to review full report at Codecov.
|
Owner
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Owner
|
+1 to merge even with the codecov fail - it's a one line deletion ... !?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously surfacing all warnings by setting
warnings.simplefilterin the source of python-twitter itself. It seems like this is a decision best left to the end user whether and how (if they just want to see the warning or if they want to error out) they would like them handled. This removes that line of code.Closes issue #403
This change is