Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Fix warnings always being displayed at library level#440

Merged
jeremylow merged 1 commit intomasterfrom
fix/issue403
Feb 16, 2017
Merged

Fix warnings always being displayed at library level#440
jeremylow merged 1 commit intomasterfrom
fix/issue403

Conversation

@jeremylow
Copy link
Copy Markdown
Collaborator

@jeremylow jeremylow commented Feb 16, 2017

We were previously surfacing all warnings by setting warnings.simplefilter in the source of python-twitter itself. It seems like this is a decision best left to the end user whether and how (if they just want to see the warning or if they want to error out) they would like them handled. This removes that line of code.

Closes issue #403


This change is Reviewable

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 16, 2017

Codecov Report

Merging #440 into master will decrease coverage by -0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   74.84%   74.83%   -0.02%     
==========================================
  Files           8        8              
  Lines        1944     1943       -1     
==========================================
- Hits         1455     1454       -1     
  Misses        489      489
Impacted Files Coverage Δ
twitter/api.py 69.4% <ø> (-0.02%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a779827...5e735cf. Read the comment docs.

@bear
Copy link
Copy Markdown
Owner

bear commented Feb 16, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@bear
Copy link
Copy Markdown
Owner

bear commented Feb 16, 2017

+1 to merge even with the codecov fail - it's a one line deletion ... !?!

@jeremylow jeremylow merged commit 88c5da0 into master Feb 16, 2017
@jeremylow jeremylow deleted the fix/issue403 branch February 16, 2017 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants