⬆ Manually upgrade OpenTK in one batch#264
Merged
tomrijnbeek merged 4 commits intomasterfrom Apr 28, 2022
Merged
Conversation
paulcscharf
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What's this?
This PR updates all the OpenTK dependencies in one go.
It also removes some unnecessary code that was there for .NET standard 2.1 only, which is no longer supported.
🔗 Relationships
Replaces #256 and #262
🔍 Why do we want this?
Dependabot only does single dependencies at a time. The OpenTK dependencies break if you use different versions for the different dependencies.
🏗 How is it done?
Manually updating the csproj, since even the NuGet UI doesn't like the one-by-one updating of packages.
💥 Breaking changes
Projects implicitly depending on the OpenTK version we provide will be broken.
🔬 Why not another way?
We could switch to the full OpenTK package which also pulls in OpenAL and other libraries, so we only ever have a single dependency to deal with.
🦋 Side effects
We had to also add an explicit dependency to
System.Runtime.CompilerServices.Unsafe, because bothOpenTKandSystem.Collections.Immutabledepend on them, but different versions. The current setup generates a warning, but tests run fine.💡 Review hints
N/A