chore(client): remove unused device_monitor attribute - #1018
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
Dropping a previously present client attribute is a potentially breaking API change and should be handled via deprecation/compatibility or explicitly confirmed as intentional.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR removes the device_monitor attribute initialization from BECClient, aligning the client surface with the current codebase usage (no internal references remain) and reducing unused API surface.
Changes:
- Remove
self.device_monitor = NonefromBECClient.__init__.
File summaries
| File | Description |
|---|---|
| bec_lib/bec_lib/client.py | Removes unused device_monitor attribute from the client initialization. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Remove unused device monitor attribute.
Related Issues
closes #508