Feature/async signal index - #957
Merged
Merged
Conversation
wakonig
force-pushed
the
feature/async_signal_index
branch
from
June 15, 2026 11:04
09f3570 to
3a38824
Compare
wakonig
force-pushed
the
feature/async_signal_index
branch
2 times, most recently
from
June 15, 2026 11:25
016ed85 to
c29d540
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wakonig
force-pushed
the
feature/async_signal_index
branch
from
June 15, 2026 12:05
c29d540 to
b2a6124
Compare
wakonig
marked this pull request as ready for review
June 15, 2026 12:06
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a companion “async signal index” channel to persist per-update indexing (+ shape metadata) for async device signal updates, enabling downstream services to correlate async updates even after the async stream data has expired.
Changes:
- Add
DeviceAsyncSignalIndexMessageand a new Redis LIST endpointdevice_async_signal_index. - Extend the device-server async signal handler to compute per-signal update indices and publish them alongside async signal updates.
- Update tests/mocks to serialize the new message and supply required async metadata in affected tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| bec_server/bec_server/device_server/bec_message_handler.py | Computes async indices and publishes index+shape companion messages to a Redis list. |
| bec_lib/bec_lib/messages.py | Introduces DeviceAsyncSignalIndexMessage message type. |
| bec_lib/bec_lib/endpoints.py | Adds device_async_signal_index endpoint (LIST op). |
| bec_lib/tests/test_bec_messages.py | Adds serialization roundtrip test for the new message type. |
| bec_lib/bec_lib/tests/utils.py | Updates ConnectorMock.rpush to accept expire (and should align better with real connector). |
| bec_server/tests/tests_device_server/test_device_manager_ds.py | Adjusts fixture and async message test inputs to include async_update metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cappel89
reviewed
Jun 26, 2026
wakonig
force-pushed
the
feature/async_signal_index
branch
3 times, most recently
from
June 26, 2026 10:47
bd94492 to
0456324
Compare
wakonig
force-pushed
the
feature/async_signal_index
branch
from
June 26, 2026 11:19
0456324 to
761d3fb
Compare
cappel89
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces async signal indices for keeping track of individual updates of async signal events. This will become useful once we have the data api and try to match async and monitored signals.
Related Issues
closes #755
Type of Change
device_async_signal_indexDeviceAsyncSignalIndexMessageHow to test