fix: bump Python base image and update deprecated PyGithub usage - #14
Merged
Conversation
Contributor
Author
|
@beckermr Please take a look. This is my first PR in this repository, so it needs an approval to trigger the CI. TY. |
Contributor
Author
|
That was quick. TYSM @beckermr. 🥳 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes conda-forge/admin-requests#2120
python:3.8-slimtopython:3.12-slim. Python 3.8 is EOL, andcryptographyhas announced it is dropping 3.8 support, which would break this image's build outright.pygithubto2.8.1instead of installing unpinned, so future major-version upgrades are deliberate rather than silent.github.Github(os.environ["GITHUB_TOKEN"])inturnstyle.pyto the non-deprecatedgithub.Github(auth=github.Auth.Token(...))form required by PyGithub 2.x.Together these resolve the two deprecation warnings currently surfacing in CI: