Skip to content

Conversation

@stefanorosanelli
Copy link
Member

@stefanorosanelli stefanorosanelli commented Mar 10, 2020

This PR adds a roles filter for users like any other enum based filter on properties.

A special virtual property is added to users JSON SCHEMA that can be used as filter.

bedita/bedita#1668 is needed to make this filter work

@codecov-io
Copy link

codecov-io commented Mar 10, 2020

Codecov Report

Merging #391 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #391      +/-   ##
============================================
+ Coverage     83.07%   83.17%   +0.09%     
- Complexity      562      564       +2     
============================================
  Files            32       32              
  Lines          1625     1634       +9     
============================================
+ Hits           1350     1359       +9     
  Misses          275      275              
Impacted Files Coverage Δ Complexity Δ
src/Controller/Component/SchemaComponent.php 91.78% <100.00%> (+1.15%) 20.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9b94c...ddf212d. Read the comment docs.

@stefanorosanelli stefanorosanelli requested a review from batopa March 11, 2020 08:41
@stefanorosanelli stefanorosanelli marked this pull request as ready for review March 11, 2020 08:59
@batopa batopa merged commit 014a2d0 into bedita:master Mar 11, 2020
@stefanorosanelli stefanorosanelli deleted the feat/roles-filter branch March 12, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants