Skip to content

Conversation

@stefanorosanelli
Copy link
Member

@stefanorosanelli stefanorosanelli commented Feb 17, 2021

In this PR a refactor and cleanup of json_meta_config template has been done.

  • some elements inherited from BEdita3 apparently not used now have been removed (ma be reintroduced later, if needed)
  • BEDITA object definition done in PHP, more readable

Elements removed:

  1. unused tags
<meta name="BEDITA.currLang" content="eng" />	    
<meta name="BEDITA.currLang2" content="en" />	       
<meta name="BEdita.base" content="<?= \Cake\Routing\Router::fullBaseUrl() ?>" />
  1. unused BEDITA attributes
  • currLang
  • currLang2
  • id
  • relations

@stefanorosanelli stefanorosanelli marked this pull request as ready for review February 18, 2021 11:22
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #521 (6e0e56f) into master (d553579) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #521   +/-   ##
=========================================
  Coverage     91.07%   91.07%           
  Complexity      708      708           
=========================================
  Files            44       44           
  Lines          2130     2130           
=========================================
  Hits           1940     1940           
  Misses          190      190           
Impacted Files Coverage Δ Complexity Δ
src/Plugin.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
src/View/AppView.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/View/Helper/PermsHelper.php 100.00% <100.00%> (ø) 8.00 <8.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01832a...6236af2. Read the comment docs.

@didoda didoda merged commit 7a35d55 into bedita:master Feb 18, 2021
@stefanorosanelli stefanorosanelli deleted the chore/plugins-meta branch August 26, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants