Skip to content

Conversation

@stefanorosanelli
Copy link
Member

This is a minor fix on PropertiesComponent => when using a multi-project setup if user session expires CacheTools::cacheKey() will try to instantiate a new API client instance that may fail because API configuration is not set.
On multi-project the project configuration file containing API config is defined in the user session.

Using startup() method instead, invoked by the callback lifecycle after beforeFilter is safer => as the session expires user is already redirected to login page.

@stefanorosanelli stefanorosanelli added the bug Something isn't working label Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #687 (22e9196) into master (fec474e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #687      +/-   ##
============================================
+ Coverage     96.06%   96.07%   +0.01%     
- Complexity      937      944       +7     
============================================
  Files            64       64              
  Lines          2843     2854      +11     
============================================
+ Hits           2731     2742      +11     
  Misses          112      112              
Impacted Files Coverage Δ
src/Controller/Component/PropertiesComponent.php 96.77% <100.00%> (-0.15%) ⬇️
src/View/Helper/LayoutHelper.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ec9cf...22e9196. Read the comment docs.

@didoda didoda merged commit 43ebc80 into bedita:master Feb 2, 2022
@didoda didoda deleted the fix/startup-component branch February 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants