Skip to content

Conversation

@stefanorosanelli
Copy link
Member

@stefanorosanelli stefanorosanelli commented Apr 1, 2022

This PR introduces the standard config/app_local.php CakePHP configuration file where environment specific settings should be set.

  • config/app.php will now be added to the repository with some defaults (that can be overridden in app_local.php)
  • config/app.default.php has been removed and a new config/app_local.example.php exemple and reference has been added
  • src/Console/Installer.php methods have been updated with their new Cake4 versions

Bonus track:

  • the new cakephp/repl plugin has been added that includes and replaces the interactive ConsoleCommand (now removed along iwth test case class)

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #748 (068b6b0) into master (f8146b1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #748      +/-   ##
============================================
- Coverage     99.51%   99.51%   -0.01%     
+ Complexity      929      928       -1     
============================================
  Files            73       72       -1     
  Lines          3085     3083       -2     
============================================
- Hits           3070     3068       -2     
  Misses           15       15              
Impacted Files Coverage Δ
src/Plugin.php 100.00% <ø> (ø)
src/Application.php 94.44% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8146b1...068b6b0. Read the comment docs.

@stefanorosanelli stefanorosanelli changed the title refactor: introduce app_local.php conf Introduce app_local.php conf Apr 5, 2022
@stefanorosanelli stefanorosanelli marked this pull request as ready for review April 5, 2022 10:20
@didoda didoda added the refactor Code refactoring label Jun 15, 2022
@didoda didoda added this to the 3.x milestone Jun 15, 2022
@stefanorosanelli stefanorosanelli merged commit 75c61b1 into bedita:master Jun 28, 2022
@stefanorosanelli stefanorosanelli deleted the refactor/app-config branch June 28, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants