Endpoints + EndpointPermissions #777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=========================================
Coverage 99.49% 99.50%
- Complexity 897 906 +9
=========================================
Files 70 71 +1
Lines 2964 3005 +41
=========================================
+ Hits 2949 2990 +41
Misses 15 15
Continue to review full report at Codecov.
|
| $this->set('readonly', $this->readonly); | ||
| $this->set('deleteonly', $this->deleteonly); | ||
|
|
||
| if ($this->resourceType === 'endpoint_permissions') { |
There was a problem hiding this comment.
We should probably add these lines in EndpointPermissionsController::index() ?
| $this->set('metaColumns', $this->meta); | ||
| $this->set('filter', []); | ||
| $this->set('schema', (array)$this->Schema->getSchema($this->resourceType)); | ||
| $this->set('schema', []); |
There was a problem hiding this comment.
are we sure it's never used?
There was a problem hiding this comment.
admin endpoints lack schema (they are not objects). am I right?
There was a problem hiding this comment.
also resources have a schema => look in config/schema_properties.php - schema is fixed on resources and dynamic on objects
2 participants
This fixes #629