Embedart should embed after fetchart command

[fortes]

Right now, it looks like embedart only embeds on import (and manually). Would be great if it could automatically embed after the fetchart command.

[sampsyo]

Seems like a good idea to me.

One oddity to note here, though: if we do this, it will be the first time that one beets plugin had to talk directly to another. Currently, fetchart and embedart run at different points in the import process, so they don't need to explicitly coordinate; if we do this, however, the beet fetchart command will have to invoke code in embedart somehow.

We should be careful about how we do this -- perhaps using the event system (i.e., a new event provided by the fetchart plugin)?

[fortes]

Yes, I'm not familiar enough with the app architecture so I thought it best to open an issue and hash it out. I think allowing plugins to use the event system seems reasonable, I can imagine future scenarios where it would make sense.

[fortes]

@sampsyo Actually, after thinking it over, it might just be simpler / better to merge the two plugins. Embedding art then becomes a setting, and there's no need to come up w/ a plugin event system for now. Thoughts?

[sampsyo]

This does sound like a reasonable tactic, with two obvious drawbacks:

• Breaking backwards-compatibility (people will need to update their config files).
• It's a bit of a shame to have one big file that does two mostly-orthogonal things. (But that's not a big deal, of course.)

What would the new plugin be called? "Albumart"?

On Sat, Aug 10, 2013 at 6:04 AM, Filipe Fortes notifications@github.com
wrote:

@sampsyo Actually, after thinking it over, it might just be simpler / better to merge the two plugins. Embedding art then becomes a setting, and there's no need to come up w/ a plugin event system for now. Thoughts?

Reply to this email directly or view it on GitHub:
#356 (comment)

[fortes]

albumart seems like a reasonable name.

I agree that the change in config file is annoying. Could beets offer to auto-update the file somehow? At least it's a very quick change...