Skip to content

fix: ftintitle can handle a list of ampersanded artists#6375

Merged
snejus merged 2 commits intobeetbox:masterfrom
fredrik:ftintitle-multiple-ampersanded-artists
Mar 2, 2026
Merged

fix: ftintitle can handle a list of ampersanded artists#6375
snejus merged 2 commits intobeetbox:masterfrom
fredrik:ftintitle-multiple-ampersanded-artists

Conversation

@fredrik
Copy link
Copy Markdown
Contributor

@fredrik fredrik commented Feb 17, 2026

Description

This was inspired by real life events:
https://musicbrainz.org/release/7c4d7a15-6b30-4bef-8b20-af200186fbdb by the artist Danny L Harle has a a track with a featuring list that contains "Danny L Harle, Oklou & MNEK".

Before:

artist = Danny L Harle, Oklou
track = Crystallise My Tears feat. MNEK

After:

artist = Danny L Harle
track = Crystallise My Tears feat. Oklou & MNEK

@fredrik fredrik requested a review from a team as a code owner February 17, 2026 07:14
@fredrik fredrik force-pushed the ftintitle-multiple-ampersanded-artists branch from 5b93cde to a2d1cd1 Compare February 17, 2026 07:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.33%. Comparing base (43a2c69) to head (b17305a).
⚠️ Report is 360 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6375   +/-   ##
=======================================
  Coverage   69.32%   69.33%           
=======================================
  Files         141      141           
  Lines       18786    18789    +3     
  Branches     3060     3061    +1     
=======================================
+ Hits        13024    13027    +3     
  Misses       5117     5117           
  Partials      645      645           
Files with missing lines Coverage Δ
beetsplug/ftintitle.py 85.71% <100.00%> (+0.36%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fredrik fredrik force-pushed the ftintitle-multiple-ampersanded-artists branch from a2d1cd1 to 0b12e9f Compare February 17, 2026 12:30
Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@snejus
Copy link
Copy Markdown
Member

snejus commented Feb 22, 2026

Just needs rebasing on master to resolve the conflict in the changelog.

@fredrik fredrik force-pushed the ftintitle-multiple-ampersanded-artists branch 2 times, most recently from 354d24a to 4fa3e53 Compare February 23, 2026 07:45
@fredrik
Copy link
Copy Markdown
Contributor Author

fredrik commented Feb 23, 2026

Just needs rebasing on master to resolve the conflict in the changelog.

Done!

The unrelated windows test failures are also green now.

This was inspired by real life events:
https://musicbrainz.org/release/7c4d7a15-6b30-4bef-8b20-af200186fbdb
by the artist Danny L Harle has a a track with a featuring list
that contains "Danny L Harle, Oklou & MNEK".
@snejus snejus force-pushed the ftintitle-multiple-ampersanded-artists branch from 4fa3e53 to bfd95f4 Compare March 2, 2026 14:53
@snejus
Copy link
Copy Markdown
Member

snejus commented Mar 2, 2026

Moved the changelog note under Unreleased section as we've had a released since the last review. Going to merge this once the CI run is finished.

@snejus snejus enabled auto-merge March 2, 2026 14:55
@snejus snejus merged commit 6089ab0 into beetbox:master Mar 2, 2026
14 checks passed
@snejus snejus added the ftintitle ftintitle plugin label Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ftintitle ftintitle plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants