Skip to content

Use tox to test on travis and add docs and flake8#643

Merged
sampsyo merged 6 commits intobeetbox:masterfrom
geigerzaehler:tox-flake8-travis
Apr 3, 2014
Merged

Use tox to test on travis and add docs and flake8#643
sampsyo merged 6 commits intobeetbox:masterfrom
geigerzaehler:tox-flake8-travis

Conversation

@geigerzaehler
Copy link
Copy Markdown

Based on the suggestions in #631.

Travis CI now also confirm that the docs build correctly and the flake8 runs succesfully. Tox also has the advantage that it tests that beets installs correctly.

Currently flake8 does not run succesfully so it is configured to not fail the build on Travis. This branch is intended to make flake8 pass. But we still have to agree on style guide.

Thomas Scholtes added 6 commits April 2, 2014 22:48
Travis CI now also confirm that the docs build correctly and the flake8 runs
succesfully. Tox also has the advantage that it tests that beets installs
correctly.

Currently flake8 does not run succesfully so it is configured to not fail the
build on Travis.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this include py26 and pypy so that just typing tox runs the same five configurations as Travis?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of this as more of local pre-commit test to be run by the user. I don’t have 2.6 and pypy on my system so I would get errors. Even if they were installed, it would nearly triple the testing time to almost no benefit because incompatibility errors are rare.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I like to have all three environments because I mess things up for 2.6 occasionally and it's nice to see exactly what Travis will run. Either way is of course cool with me since the -e flag there for overriding the default set.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, FWIW: I've been interested in trying detox to speed this up on my machine.

@sampsyo
Copy link
Copy Markdown
Member

sampsyo commented Apr 3, 2014

I love it! ✨ I didn't know Travis gave you access to all the Python version even when the Travis environment was fixed (2.7 here). This is great since it gives tox control over what should run so we can test it locally. Yay!

I'm so excited about having this (including the docs build on Travis) that I'll merge immediately.

sampsyo added a commit that referenced this pull request Apr 3, 2014
Use tox to test on travis and add docs and flake8
@sampsyo sampsyo merged commit c4be9c2 into beetbox:master Apr 3, 2014
sampsyo added a commit that referenced this pull request Apr 3, 2014
@geigerzaehler geigerzaehler deleted the tox-flake8-travis branch April 3, 2014 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants