Skip to content

fix(deezer): use artist ID to detect Various Artists releases#6499

Merged
snejus merged 1 commit intobeetbox:masterfrom
aaronk6:deezer-language-fix
Apr 5, 2026
Merged

fix(deezer): use artist ID to detect Various Artists releases#6499
snejus merged 1 commit intobeetbox:masterfrom
aaronk6:deezer-language-fix

Conversation

@aaronk6
Copy link
Copy Markdown
Contributor

@aaronk6 aaronk6 commented Apr 4, 2026

Description

Fixes #4956

The Deezer API apparently uses IP geolocation to return a localized “Various Artists” name (e.g. “Verschiedene Interpreten” in German), causing VA releases to match poorly and display the wrong artist name.

This implements the approach suggested by @sampsyo in beetbox/beets#4956: detect VA releases using Deezer’s (hopefully) stable various artists ID (5080) instead of a string comparison, then replace the localized name with the user’s configured va_name, mirroring what the MusicBrainz plugin already does with its own VARIOUS_ARTISTS_ID.

To Do

  • Documentation.
  • Changelog.
  • Tests.

@aaronk6 aaronk6 requested a review from a team as a code owner April 4, 2026 21:42
Copilot AI review requested due to automatic review settings April 4, 2026 21:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

grug see PR fix Deezer Various Artists problem when API give localized name (like German). PR try detect VA by stable Deezer artist id (5080) and then use user va_name, like MusicBrainz plugin do.

Changes:

  • add Deezer VARIOUS_ARTISTS_ID = 5080 constant
  • detect VA albums via artist id and set album artist (and artist_credit) to configured va_name
  • simplify AlbumInfo.va flag to use this id-based check

@aaronk6 aaronk6 force-pushed the deezer-language-fix branch from 350d765 to 975c910 Compare April 4, 2026 21:46
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.16%. Comparing base (095ec96) to head (4492544).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
beetsplug/deezer.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6499      +/-   ##
==========================================
- Coverage   70.17%   70.16%   -0.01%     
==========================================
  Files         147      147              
  Lines       18657    18662       +5     
  Branches     3039     3040       +1     
==========================================
+ Hits        13092    13095       +3     
- Misses       4923     4926       +3     
+ Partials      642      641       -1     
Files with missing lines Coverage Δ
beetsplug/deezer.py 17.85% <33.33%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aaronk6 aaronk6 force-pushed the deezer-language-fix branch from 975c910 to d244328 Compare April 4, 2026 21:57
@snejus snejus changed the title fix(deezer): use artist ID to detect Various Artists releases fix(deezer): use artist ID to detect Various Artists release Apr 5, 2026
@snejus snejus changed the title fix(deezer): use artist ID to detect Various Artists release fix(deezer): use artist ID to detect Various Artists releases Apr 5, 2026
@snejus snejus changed the title fix(deezer): use artist ID to detect Various Artists releases fix(deezer): use artist ID to detect Various Artists release Apr 5, 2026
@snejus snejus changed the title fix(deezer): use artist ID to detect Various Artists release fix(deezer): use artist ID to detect Various Artists releases Apr 5, 2026
Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just add a note to the changelog please.

@snejus snejus changed the title fix(deezer): use artist ID to detect Various Artists releases fix(deezer): use artist ID to detect Various Artists release Apr 5, 2026
@github-actions github-actions bot added the deezer deezer plugin label Apr 5, 2026
@snejus snejus changed the title fix(deezer): use artist ID to detect Various Artists release fix(deezer): use artist ID to detect Various Artists releases Apr 5, 2026
@snejus
Copy link
Copy Markdown
Member

snejus commented Apr 5, 2026

Please ignore my attempts to adjust the PR title 😁 I was testing our new workflow which automatically adds plugin labels to PRs.

@aaronk6 aaronk6 force-pushed the deezer-language-fix branch 2 times, most recently from 99a136b to d1a31b5 Compare April 5, 2026 20:28
@snejus
Copy link
Copy Markdown
Member

snejus commented Apr 5, 2026

@aaronk6 see below

Looks great, just add a note to the changelog please.

@aaronk6
Copy link
Copy Markdown
Contributor Author

aaronk6 commented Apr 5, 2026

@snejus It’s done now. Thanks for the review!

@snejus snejus force-pushed the deezer-language-fix branch from d1a31b5 to 4492544 Compare April 5, 2026 21:16
@snejus snejus enabled auto-merge April 5, 2026 21:16
@snejus snejus merged commit 657a3a2 into beetbox:master Apr 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deezer deezer plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deezer: Sometimes uses locale-specific name for "Various Artists"

3 participants