fix(deezer): use artist ID to detect Various Artists releases#6499
fix(deezer): use artist ID to detect Various Artists releases#6499snejus merged 1 commit intobeetbox:masterfrom
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
There was a problem hiding this comment.
Pull request overview
grug see PR fix Deezer Various Artists problem when API give localized name (like German). PR try detect VA by stable Deezer artist id (5080) and then use user va_name, like MusicBrainz plugin do.
Changes:
- add Deezer
VARIOUS_ARTISTS_ID = 5080constant - detect VA albums via artist id and set album
artist(andartist_credit) to configuredva_name - simplify
AlbumInfo.vaflag to use this id-based check
350d765 to
975c910
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6499 +/- ##
==========================================
- Coverage 70.17% 70.16% -0.01%
==========================================
Files 147 147
Lines 18657 18662 +5
Branches 3039 3040 +1
==========================================
+ Hits 13092 13095 +3
- Misses 4923 4926 +3
+ Partials 642 641 -1
🚀 New features to boost your workflow:
|
975c910 to
d244328
Compare
snejus
left a comment
There was a problem hiding this comment.
Looks great, just add a note to the changelog please.
|
Please ignore my attempts to adjust the PR title 😁 I was testing our new workflow which automatically adds plugin labels to PRs. |
99a136b to
d1a31b5
Compare
|
@aaronk6 see below
|
|
@snejus It’s done now. Thanks for the review! |
d1a31b5 to
4492544
Compare
Description
Fixes #4956
The Deezer API apparently uses IP geolocation to return a localized “Various Artists” name (e.g. “Verschiedene Interpreten” in German), causing VA releases to match poorly and display the wrong artist name.
This implements the approach suggested by @sampsyo in beetbox/beets#4956: detect VA releases using Deezer’s (hopefully) stable various artists ID (5080) instead of a string comparison, then replace the localized name with the user’s configured
va_name, mirroring what the MusicBrainz plugin already does with its ownVARIOUS_ARTISTS_ID.To Do