Use aliases for artist credit

[Morikko]

Description

The *_credit fields for album and track are also aliased.

Follow up of #6231. I wanted to mbsync my library but then I realized that *_credit fields were reverted to non-alias if already aliased.

I don't how I got those aliased in the first place as the code is not using them since years. Also, I had 2 albums added the same day and one was with aliased credit and the other one not.

Discussed here: #6358 (comment)

To Do

• Documentation (nothing to add since it is already said that artist is aliased)
• Changelog.
• Tests. (Somehow artist aliased assertion were missing so I add them as well)

[snejus]

Nice, thanks!

[amogus07]

Aren't the *_credit fields specifically intended to store the canonical way artists are credited for a specific entity?

[snejus]

Good question. My understanding is that *_credit fields are meant to preserve release/recording-specific credited text (MusicBrainz artist_credit[].name), while alias preferences are usually applied to artist and artist_sort.

This PR intentionally applied aliases to *_credit too, mainly to avoid value churn for users running mbsync with language aliases enabled.

Your concern is valid, but since we don't have a concrete regression from the current behavior, I suggest we keep this as-is for now and revisit if someone reports a real issue with it.

[djl]

This change may have a large impact on people's libraries. I ran mbsync over my library and all *_credit fields have been changed to use aliases, which is not correct.

One example would be Yasiin Bey. The older releases are now tagged with the current alias, not what they're actually credited as.

I suspect users may complain about this when this eventually reaches a release.

[snejus]

I suspect users may complain about this when this eventually reaches a release.

This has already been released in 2.10.0. Let's see, if that's the case I'm happy to revert it!

[djl]

I can see some users actually wanting this, but definitely not all (e.g. me!). It would make sense to make this an opt-in feature, due to it completely overwriting existing data en-masse.

[snejus]

@djl would you be happy to submit a PR to make this an opt-in?

[djl]

Can do. Should be up tomorrow.