Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Contributor
There was a problem hiding this comment.
Pull request overview
PR remove old slow_test unittest marker plumbing. Grug see goal is make test suite simpler by always running tests, and delete unused env-var skip path.
Changes:
- Remove
slow_test()helper and itsSKIP_SLOW_TESTSbehavior frombeets/test/_common.py. - Drop
@_common.slow_test()decorators across test modules (tests now run always). - Remove
SKIP_SLOW_TESTSdocs fromCONTRIBUTING.rst.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/ui/test_ui.py | Remove slow_test decorator from plugin-related test classes. |
| test/ui/commands/test_completion.py | Remove slow_test decorator from completion tests. |
| test/test_logging.py | Remove slow_test decorator and now-unused _common import. |
| test/test_importer.py | Remove slow_test decorator from importer test class. |
| test/test_dbcore.py | Remove slow_test decorator and now-unused _common import. |
| test/plugins/test_edit.py | Remove slow_test decorators and now-unused _common import. |
| test/plugins/test_convert.py | Remove slow_test decorators from convert-related test classes. |
| test/plugins/test_art.py | Remove slow_test decorator from art importer tests. |
| beets/test/_common.py | Delete slow_test() helper (and unittest import). |
| CONTRIBUTING.rst | Remove documentation for SKIP_SLOW_TESTS. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6569 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 159 159
Lines 20528 20528
Branches 3264 3264
=======================================
Hits 14734 14734
Misses 5105 5105
Partials 689 689 🚀 New features to boost your workflow:
|
f55732d to
ccdccdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
slow_testunittest markerRemoves the
slow_testdecorator and its supportingSKIP_SLOW_TESTSenv-var mechanism entirely. All previously "slow" test classes now run unconditionally.Changes:
slow_test()helper frombeets/test/_common.py@_common.slow_test()usages across test filesCONTRIBUTING.rstto drop theSKIP_SLOW_TESTSdocumentationJust doing some plumbing removing some unused noise from tests.