badfiles: respect import.quiet during import hook#6589
Merged
Conversation
eyupcanakman
force-pushed
the
fix/badfiles-quiet-mode
branch
2 times, most recently
from
68c8057 to
453b4bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6589 +/- ##
==========================================
+ Coverage 72.03% 72.07% +0.04%
==========================================
Files 159 159
Lines 20631 20633 +2
Branches 3272 3273 +1
==========================================
+ Hits 14861 14871 +10
+ Misses 5063 5053 -10
- Partials 707 709 +2
🚀 New features to boost your workflow:
|
eyupcanakman
force-pushed
the
fix/badfiles-quiet-mode
branch
from
453b4bc to
01baa75
Compare
snejus
requested changes
Apr 28, 2026
snejus
approved these changes
Apr 30, 2026
Member
snejus
left a comment
snejus
left a comment
There was a problem hiding this comment.
Nice, thanks. Just rebase it on top of master and resolve the conflict in the changelog.
The import hook prompted for input even when quiet mode was active, so non-interactive imports blocked on the corrupt-file dialog. Return early from `on_import_task_before_choice` when `import.quiet` is set so the importer falls back to its summary judgment.
eyupcanakman
force-pushed
the
fix/badfiles-quiet-mode
branch
from
2501783 to
382ec79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The badfiles plugin's
on_import_task_before_choicehook prompted for input even when quiet mode was active. Non-interactive imports stalled on the corrupt-file dialog. The hook now returns early whenimport.quietis set, so the importer falls back to its summary judgment under both the--quietflag and theimport.quiet: yesconfig key.Fixes #4736.
To Do
Documentation