Fix mpdstats CLI option overrides#6699
Open
Tsuizxgo wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6699 +/- ##
==========================================
+ Coverage 72.59% 72.66% +0.06%
==========================================
Files 162 162
Lines 20811 20805 -6
Branches 3293 3290 -3
==========================================
+ Hits 15107 15117 +10
+ Misses 4980 4964 -16
Partials 724 724
🚀 New features to boost your workflow:
|
snejus
approved these changes
Jun 4, 2026
Member
|
Can you rebase this on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5404.
The
mpdstatscommand already overlays CLI options onto thempdconfig withmpd_config.set_args(opts). After that, it tried to manually apply the same options again, which caused two problems on Python 3:--hostand--passwordvalues are already strings, so calling.decode("utf-8")crashed.--portwas accidentally assigned tompd_config["host"], producing an invalid host configuration.This change removes the redundant manual override block and relies on
set_args()to preserve the correct option types.To Do
Documentation.This is a bug fix for existing CLI options.docs/changelog.rst.--host,--port, and--passwordoverrides.Tests