fix(web): DRGARE dredged-depth labels convert with the depth-unit set…#11
Merged
Conversation
…ting DredgedArea.lua bakes the dredged depth (DRVAL1) as a fixed-metres "%gm" text label, so it never reconverted when the mariner switched to feet — the same bug class as the recent sounding/contour fixes. Drop the static DRGARE depth DrawText at bake (the area already carries drval1) and label the dredged area client-side from drval1 in the chosen depth unit, via a new `drgare-labels` layer + s52-style.drgareLabelField — mirroring the contour-labels/valdco pattern. Feet round to whole, metres keep one decimal. Verified end-to-end (US5MD1MC, Annapolis): the fixed bake drops the static "1.8m/2.2m/3.2m/4.1m" labels (name labels preserved); the same areas render 4.9m/4.5m/1.8m in metric and 16ft/15ft/6ft in imperial. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ting
DredgedArea.lua bakes the dredged depth (DRVAL1) as a fixed-metres "%gm" text label, so it never reconverted when the mariner switched to feet — the same bug class as the recent sounding/contour fixes.
Drop the static DRGARE depth DrawText at bake (the area already carries drval1) and label the dredged area client-side from drval1 in the chosen depth unit, via a new
drgare-labelslayer + s52-style.drgareLabelField — mirroring the contour-labels/valdco pattern. Feet round to whole, metres keep one decimal.Verified end-to-end (US5MD1MC, Annapolis): the fixed bake drops the static "1.8m/2.2m/3.2m/4.1m" labels (name labels preserved); the same areas render 4.9m/4.5m/1.8m in metric and 16ft/15ft/6ft in imperial.