fix(symbols): render S-101 even-odd danger symbols with their holes#19
Merged
Conversation
Every S-101 symbol is authored with fill-rule="evenodd", but the symbol rasterizer ignored it: oksvg never parses fill-rule and rasterx's ScannerGV.SetWinding is a no-op (nonzero-only). So compound glyphs like ISODGR01/DANGER0x — an outer body with an inner subpath meant to be a hole — filled solid, e.g. an ISODGR01 with no star in it. Force even-odd winding on every parsed path and rasterize through scanFT (freetype-backed, pure Go / CGO-free), whose SetWinding honours even-odd. For simple non-self-intersecting paths even-odd and nonzero are identical, so the rest of the catalogue is unaffected. Adds a self-contained regression test (no catalogue needed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every S-101 symbol is authored with fill-rule="evenodd", but the symbol rasterizer ignored it: oksvg never parses fill-rule and rasterx's ScannerGV.SetWinding is a no-op (nonzero-only). So compound glyphs like ISODGR01/DANGER0x — an outer body with an inner subpath meant to be a hole — filled solid, e.g. an ISODGR01 with no star in it.
Force even-odd winding on every parsed path and rasterize through scanFT (freetype-backed, pure Go / CGO-free), whose SetWinding honours even-odd. For simple non-self-intersecting paths even-odd and nonzero are identical, so the rest of the catalogue is unaffected.
Adds a self-contained regression test (no catalogue needed).