fix(tools): compile the tile57 CLI for Windows (gate the POSIX-only -…#1
Merged
Conversation
…-tui) The interactive `ascii --tui` / `explore --tui` loops enter raw mode via std.posix termios, whose type is `void` on Windows — so `raw.lflag.ICANON` failed to compile and broke `zig build` for x86_64/aarch64-windows-gnu. That in turn broke chartplotter's release cross-build: libtile57.a compiles fine, but the bundled `tile57` CLI exe (built by the same default `zig build`) did not. Gate each TUI body behind a comptime `builtin.os.tag == .windows` early return — the same idiom common.zig's terminalSize already uses — so the POSIX-only code is analysed out on Windows and the CLI compiles for every release target. `--tui` prints "not supported on Windows" there; batch render paths are unaffected. Also add engine CI (was docs-only): native build + `zig build test`, plus a cross-compile matrix over linux/windows amd64/arm64, so a target that fails to build is caught in the engine repo rather than only downstream at chartplotter release time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
beetlebugorg
force-pushed
the
fix/windows-cross-compile
branch
from
1b02d24 to
b3da4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-tui)
The interactive
ascii --tui/explore --tuiloops enter raw mode via std.posix termios, whose type isvoidon Windows — soraw.lflag.ICANONfailed to compile and brokezig buildfor x86_64/aarch64-windows-gnu. That in turn broke chartplotter's release cross-build: libtile57.a compiles fine, but the bundledtile57CLI exe (built by the same defaultzig build) did not.Gate each TUI body behind a comptime
builtin.os.tag == .windowsearly return — the same idiom common.zig's terminalSize already uses — so the POSIX-only code is analysed out on Windows and the CLI compiles for every release target.--tuiprints "not supported on Windows" there; batch render paths are unaffected.Also add engine CI (was docs-only): native build +
zig build test, plus a cross-compile matrix over linux/windows amd64/arm64, so a target that fails to build is caught in the engine repo rather than only downstream at chartplotter release time.