Enable beman-tidy default mode on beman.utf_view#240
Closed
neatudarius wants to merge 1 commit into
Closed
Conversation
Issue: bemanproject/beman-tidy#265 Move SPDX license identifiers to line 2 in paper generator scripts and run beman-tidy in default mode (requirements only) on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bemanproject/beman-tidy#265
Problem
beman-tidyin default mode (requirements only) was failing onfile.license_idfor two paper generator scripts where the SPDX identifier was on line 3 instead of line 2.Upstream
mainalso had--require-allenabled in pre-commit prematurely.Changes
papers/generator/generator.shandpapers/generator/post_clang_format.pybeman-tidyin default mode on CI (remove--require-allfrom.pre-commit-config.yaml)beman-tidy results (local, default mode)
Recommendations still failing are already disabled in
.beman-tidy.yaml(license.apache_llvm,file.copyright,readme.implements).Supersedes #239 (could not reopen after force-push while closed).