Fix trunk checker fail by AndreiDurlea · Pull Request #145 · bemanproject/website

AndreiDurlea · 2026-03-30T01:04:36Z

TL;DR

Resolved a plethora of warnings and errors while also upgrading trunk to its latest version in the process.

Summary

Fixed up some .md files
Removed some conflicts of trunk with docusaurus itself by adding some ignoring in config files
- Vulnerabilities in some of its dependencies
- Markdownlint conflicts that are usually ignored in standard docusaurus projects
Upgraded trunk and removed check-mode: all as that has been deprecated

netlify · 2026-03-30T01:04:41Z

✅ Deploy Preview for bemanproject ready!

Name	Link
🔨 Latest commit	`5f73d66`
🔍 Latest deploy log	https://app.netlify.com/projects/bemanproject/deploys/69cbb89a2f263400081cafaa
😎 Deploy Preview	https://deploy-preview-145--bemanproject.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…atting styles

Also deleted package-lock.json which was leftover from a npm run

And upgrade of two packages

AndreiDurlea · 2026-03-30T01:41:11Z

We have victory, finally, the website checks are green!
@neatudarius is this ok to merge?

Accidental; were supposed for bemanproject#145

neatudarius · 2026-03-30T21:33:14Z

We have victory, finally, the website checks are green! @neatudarius is this ok to merge?

Thanks @AndreiDurlea ! This is a good direction and initiative. Thanks! However, some pieces of this PR cannot be merged.

We need to distinguish between manual generated files and autogenerated files. I'm working on docs import automation from beman/ repo. The script is ready https://github.com/bemanproject/website/tree/main/scripts - can be tested; I'm working on finalizing CI automation here #51.

TLDR: I will tag some files that should be excluded from the checker, not fixed. They are imported from other repos, and we should keep it as it is, otherwise automation cannot be achieved. Basically we need to first solved #126, and then update your PR to only fix files that are not imported.

neatudarius

Did a full pass- thanks @AndreiDurlea - lots of good things here, and a few which can be improved. Please check the large comment here: https://github.com/bemanproject/website/pull/145/changes#r3012387061. Let's first check if we can resolve this comment as proposed. Successful path will simplify this PR!

neatudarius · 2026-03-30T21:34:30Z

We should keep your changes in .github / .trunk directories.

neatudarius · 2026-03-30T21:35:31Z

Changes in this files are also OK to keep.

neatudarius · 2026-03-30T21:45:21Z

This file is manually created only in website! We can do changes here, ofc.

neatudarius · 2026-03-30T21:45:40Z

 slug: libraries
 ---

-# Beman Libraries


Why do we remove the title? We must keep it.

neatudarius · 2026-03-30T21:47:05Z

Can we remove this file? I think it's a leftover from used template.

neatudarius · 2026-03-30T21:48:56Z

We keep changes here.

neatudarius · 2026-03-30T21:50:51Z

We keep changes here if it's working - please check the render version of each changed MD!

neatudarius · 2026-03-30T21:55:31Z

P1: First of all, we should not manually change images in docs/images and images/ and static/ directories for 2 reasons.

We want to be an identical copy of what we have in beman/ & other repos. If we need to fix them, we should first fix them in a new PR, and then import them here. That's the flow! The website content is always a mirror of the latest status of the beman libraries/beman repo.

If you do this change here, and do not do 1 first, it's pointless to sync the next run of sync-docs.py (manual or soon automated on CI), which will import the images from other repos.

============================================================================

P2: Similar to all md files in https://github.com/bemanproject/website/tree/main/docs, which are automatically imported by the script.

============================================================================

My request here is to exclude from linter files in docs/*.md, docs/images/, images/, static/docs/images, static/images/, static/img/.

Then we can drop the changes into the current PR across all the mentioned directories and still get the CI trunk check green. This would be the desired solution for both #126 and #118.

We can then discuss and update docs and images outside this repo, and here just re-import them.

See here #51 / #152. Just finished automation for doc import. This is where we should be!

Alright, makes sense, will be doing this

…ea/beman-website into andreidurlea-issue118

Also added explainers

AndreiDurlea · 2026-03-31T12:09:41Z

@neatudarius I finished applying the requested changes. Turns out running trunk fmt --all does breaking changes. Especially when running it at 3AM when I'm less likely to look twice over everything =) Lesson learned. Thank you for cathing those problems in the review

neatudarius

LGTM!

Good to see this lint job passing

neatudarius · 2026-03-31T22:57:54Z

@@ -17,6 +17,17 @@ runtimes:
    - python@3.10.8
 # This is the section where you manage your linters. (https://docs.trunk.io/check/configuration)
 lint:


Remove unnecessary f-strings

2954267

AndreiDurlea force-pushed the andreidurlea-issue118 branch 2 times, most recently from 433ecf5 to 9245f2f Compare March 30, 2026 01:17

AndreiDurlea added 2 commits March 30, 2026 04:22

Lowered deploy permissions

208fac0

Ignore markdownlint rules that conflict with standard Docusaurus form…

cb77587

…atting styles

AndreiDurlea force-pushed the andreidurlea-issue118 branch from 9245f2f to 900095f Compare March 30, 2026 01:22

Trunk checker fixes megacommit

26006bf

Also deleted package-lock.json which was leftover from a npm run

AndreiDurlea force-pushed the andreidurlea-issue118 branch from 900095f to 3ee8f5d Compare March 30, 2026 01:26

Markdown trunk fixes

e34834c

And upgrade of two packages

AndreiDurlea force-pushed the andreidurlea-issue118 branch from 3ee8f5d to e34834c Compare March 30, 2026 01:28

AndreiDurlea added 2 commits March 30, 2026 04:34

Have osv ignore yarn.lock

7290c98

remove deprecated check-mode in trunk github action

46db726

AndreiDurlea mentioned this pull request Mar 30, 2026

Added discord to website text #144

Merged

AndreiDurlea added a commit to AndreiDurlea/beman-website that referenced this pull request Mar 30, 2026

Reverted yarn.lock changes

2403485

Accidental; were supposed for bemanproject#145

neatudarius requested changes Mar 30, 2026

View reviewed changes

AndreiDurlea added 2 commits March 31, 2026 11:19

Rollback mirrored files to original state

8ed16bf

Added ignoring in trunk for auto imported files

28fefd8

AndreiDurlea force-pushed the andreidurlea-issue118 branch from 29b6a88 to 28fefd8 Compare March 31, 2026 08:19

AndreiDurlea added 3 commits March 31, 2026 11:19

Added ignoring in trunk for auto imported files

c120120

Merge branch 'andreidurlea-issue118' of https://github.com/AndreiDurl…

1c883e5

…ea/beman-website into andreidurlea-issue118

Remove leftover example page

2ae1e56

AndreiDurlea force-pushed the andreidurlea-issue118 branch from 82116f8 to b310687 Compare March 31, 2026 11:32

Fixed library.md display

9c4c88a

AndreiDurlea force-pushed the andreidurlea-issue118 branch from b310687 to 9c4c88a Compare March 31, 2026 11:39

AndreiDurlea added 2 commits March 31, 2026 14:51

chore: apply trunk fmt fixes

ae093ce

Removed unnecessary markdownlint rule ignores

b6b94c3

Also added explainers

AndreiDurlea requested a review from neatudarius March 31, 2026 12:02

AndreiDurlea added 2 commits March 31, 2026 15:03

Removed unnecessary markdownlint rule ignores

9d0ed23

Also added explainers

chore: fixed markdownlint.yml according to trunk

5f73d66

AndreiDurlea force-pushed the andreidurlea-issue118 branch from fa91977 to 5f73d66 Compare March 31, 2026 12:05

neatudarius marked this pull request as ready for review March 31, 2026 22:59

neatudarius requested review from JeffGarland, RaduNichita, camio, ednolan, inbal2l and mguludag as code owners March 31, 2026 22:59

neatudarius approved these changes Mar 31, 2026

View reviewed changes

neatudarius merged commit d68be54 into bemanproject:main Mar 31, 2026
5 checks passed

AndreiDurlea mentioned this pull request Apr 1, 2026

Disable linting on autogenerated code #126

Closed

2 tasks

Uh oh!

Conversation

AndreiDurlea commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

Summary

Uh oh!

netlify Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for bemanproject ready!

Uh oh!

AndreiDurlea commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neatudarius commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neatudarius left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndreiDurlea commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neatudarius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AndreiDurlea commented Mar 30, 2026 •

edited

Loading

netlify Bot commented Mar 30, 2026 •

edited

Loading

AndreiDurlea commented Mar 30, 2026 •

edited

Loading

neatudarius commented Mar 30, 2026 •

edited

Loading

neatudarius left a comment •

edited

Loading

AndreiDurlea commented Mar 31, 2026 •

edited

Loading