Fix trusted run stopping at commit flow due to pending checks - #45
Merged
Conversation
Fixes issue where trusted run stopped at commit flow due to pending checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
next_flowfunction insrc/services/trusted.rsto handle cases where a pull request's checks are still pending.Why
The previous implementation stopped every trusted run at the commit flow due to pending checks, even though a person is not expected to act on these checks. This change ensures that the flow continues to the review stage, where the diff can be reviewed while CI runs, and the merge rules already handle the refusal to merge on pending checks.
How to test