Skip to content

Add additional check for horizontal scroll compatability#2

Open
homerjam wants to merge 1 commit into
benpickles:masterfrom
homerjam:master
Open

Add additional check for horizontal scroll compatability#2
homerjam wants to merge 1 commit into
benpickles:masterfrom
homerjam:master

Conversation

@homerjam
Copy link
Copy Markdown

No description provided.

@benpickles
Copy link
Copy Markdown
Owner

Hey that's great, I hadn't even thought of horizontal positioning!

I haven't had a chance to test this out yet but I have a few requests for the commit (sorry):

  • Don't bother generating the minified version, I'll do that when it's released.
  • Ditto for updating the version number.
  • Try not to reformat the whole document(!): it's changed from 2 spaces to 4; semicolons have been added to the end of lines; the preceding semicolon has disappeared; there's no longer a newline at the end of the file.

Otherwise, thanks for taking the time to put the pull request together 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants