io: Return the pooled reader directly from bufferedReader - #70
Merged
Conversation
Let bytesAndReader implement readerCloser itself instead of wrapping it
in a closure and an anonymous struct per call. This cuts two allocations
per out-of-line EXIF tag value:
``` │ main.bench │ benchevanoberholsterimagemeta.bench │
│ sec/op │ sec/op vs base │
DecodeCompareWithGoexif/bep/imagemeta/exif/jpeg/alltags-10 17.58µ ± ∞ ¹ 16.04µ ± ∞ ¹ -8.76% (p=0.029 n=4)
DecodeCompareWithGoexif/bep/imagemeta/exif/jpeg/orientation-10 2.629µ ± ∞ ¹ 2.565µ ± ∞ ¹ -2.43% (p=0.029 n=4)
DecodeCompareWithGoexif/rwcarlsen/goexif/exif/jpg/alltags-10 44.57µ ± ∞ ¹ 44.71µ ± ∞ ¹ ~ (p=0.343 n=4)
geomean 12.72µ 12.25µ -3.70%
¹ need >= 6 samples for confidence interval at level 0.95
│ main.bench │ benchevanoberholsterimagemeta.bench │
│ B/op │ B/op vs base │
DecodeCompareWithGoexif/bep/imagemeta/exif/jpeg/alltags-10 4.422Ki ± ∞ ¹ 2.965Ki ± ∞ ¹ -32.95% (p=0.029 n=4)
DecodeCompareWithGoexif/bep/imagemeta/exif/jpeg/orientation-10 549.0 ± ∞ ¹ 501.0 ± ∞ ¹ -8.74% (p=0.029 n=4)
DecodeCompareWithGoexif/rwcarlsen/goexif/exif/jpg/alltags-10 138.6Ki ± ∞ ¹ 138.6Ki ± ∞ ¹ ~ (p=1.000 n=4) ²
geomean 6.901Ki 5.859Ki -15.10%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
│ main.bench │ benchevanoberholsterimagemeta.bench │
│ allocs/op │ allocs/op vs base │
DecodeCompareWithGoexif/bep/imagemeta/exif/jpeg/alltags-10 190.0 ± ∞ ¹ 128.0 ± ∞ ¹ -32.63% (p=0.029 n=4)
DecodeCompareWithGoexif/bep/imagemeta/exif/jpeg/orientation-10 13.00 ± ∞ ¹ 11.00 ± ∞ ¹ -15.38% (p=0.029 n=4)
DecodeCompareWithGoexif/rwcarlsen/goexif/exif/jpg/alltags-10 816.0 ± ∞ ¹ 816.0 ± ∞ ¹ ~ (p=1.000 n=4) ²
geomean 126.3 104.7 -17.08%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
````
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 78.62% 78.95% +0.33%
==========================================
Files 16 16
Lines 2129 2115 -14
==========================================
- Hits 1674 1670 -4
+ Misses 314 305 -9
+ Partials 141 140 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let bytesAndReader implement readerCloser itself instead of wrapping it
in a closure and an anonymous struct per call. This cuts two allocations
per out-of-line EXIF tag value:
Co-Authored-By: Claude Fable 5 noreply@anthropic.com