Conversation
- Fixed CsvHelper attribute for `subjectCodes` in `ClassFile` - Renamed and added demographic fields in `DemographicFile` (`nativeHawaiianOrOtherPacificIslander`, `white`, `demographicRaceTwoOrMoreRaces`, `hispanicOrLatinoEthnicity`) - Updated `DemographicFile.Map` to map new fields and lowercase values - Added `courseSourcedId` to `EnrollmentFile` and mapped in `Map` method
There was a problem hiding this comment.
Pull request overview
This PR updates the OneRoster CSV export schema to better match the documented v1.2 column names/expectations (notably demographics/enrollments/classes) and bumps the package version to a new beta.
Changes:
- Bump package version and document the new beta release in README.
- Update export DTO column names/columns for
demographics.csv,enrollments.csv, andclasses.csv. - Add
courseSourcedIdcolumn support to the enrollments export.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a 2.1.1-beta entry describing the CSV schema fixes. |
| OneRosterSampleDataGenerator/OneRosterSampleDataGenerator.csproj | Bumps NuGet/package version to 2.1.1-beta. |
| OneRosterSampleDataGenerator/Models/Exports/EnrollmentFile.cs | Adds courseSourcedId column to enrollments export and maps it. |
| OneRosterSampleDataGenerator/Models/Exports/DemographicFile.cs | Fixes/extends demographics export columns and mapping to better match v1.2. |
| OneRosterSampleDataGenerator/Models/Exports/ClassFile.cs | Fixes subjectCodes column name casing for classes export. |
Comments suppressed due to low confidence (1)
OneRosterSampleDataGenerator/Models/Exports/DemographicFile.cs:39
- The demographics.csv header name for state of birth is currently "stateofBirthAbbreviation", but the repository spec doc (docs/plan.md) calls for "stateOfBirthAbbreviation". This mismatch can break consumers that expect the spec header.
public string HispanicOrLatinoEthnicity { get; set; } = null!;
[Name("countryOfBirthCode")]
public string CountryOfBirthCode { get; set; } = null!;
[Name("stateofBirthAbbreviation")]
public string StateofBirthAbbreviation { get; set; } = null!;
Added Asian property to Demographic and export mapping. Fixed typo: HispanicOrLationEthnicity → HispanicOrLatinoEthnicity. Moved courseSourcedId to end of EnrollmentFile export for correct output order.
bergerb
deleted the
51-add-missing-demographicscsv-columns-white-demographicracetwoormoreraces-hispanicorlatinoethnicity
branch
July 10, 2026 01:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Fixes #52
Fixes #53
Fixes #54
Fixes #55