Skip to content

51 add missing demographicscsv columns white demographicracetwoormoreraces hispanicorlatinoethnicity#60

Merged
bergerb merged 3 commits into
mainfrom
51-add-missing-demographicscsv-columns-white-demographicracetwoormoreraces-hispanicorlatinoethnicity
Jul 10, 2026
Merged

51 add missing demographicscsv columns white demographicracetwoormoreraces hispanicorlatinoethnicity#60
bergerb merged 3 commits into
mainfrom
51-add-missing-demographicscsv-columns-white-demographicracetwoormoreraces-hispanicorlatinoethnicity

Conversation

@bergerb

@bergerb bergerb commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Fixes #51
Fixes #52
Fixes #53
Fixes #54
Fixes #55

bergerb added 2 commits July 9, 2026 21:21
- Fixed CsvHelper attribute for `subjectCodes` in `ClassFile`
- Renamed and added demographic fields in `DemographicFile` (`nativeHawaiianOrOtherPacificIslander`, `white`, `demographicRaceTwoOrMoreRaces`, `hispanicOrLatinoEthnicity`)
- Updated `DemographicFile.Map` to map new fields and lowercase values
- Added `courseSourcedId` to `EnrollmentFile` and mapped in `Map` method
Fix CSV schema issues and bump version to 2.1.1-beta

- Update demographics.csv column names and add missing columns
- Correct classes.csv SubjectCodes casing to subjectCodes
- Add missing courseSourcedId to enrollments.csv
- Update project version and README for 2.1.1-beta
Copilot AI review requested due to automatic review settings July 10, 2026 01:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OneRoster CSV export schema to better match the documented v1.2 column names/expectations (notably demographics/enrollments/classes) and bumps the package version to a new beta.

Changes:

  • Bump package version and document the new beta release in README.
  • Update export DTO column names/columns for demographics.csv, enrollments.csv, and classes.csv.
  • Add courseSourcedId column support to the enrollments export.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Adds a 2.1.1-beta entry describing the CSV schema fixes.
OneRosterSampleDataGenerator/OneRosterSampleDataGenerator.csproj Bumps NuGet/package version to 2.1.1-beta.
OneRosterSampleDataGenerator/Models/Exports/EnrollmentFile.cs Adds courseSourcedId column to enrollments export and maps it.
OneRosterSampleDataGenerator/Models/Exports/DemographicFile.cs Fixes/extends demographics export columns and mapping to better match v1.2.
OneRosterSampleDataGenerator/Models/Exports/ClassFile.cs Fixes subjectCodes column name casing for classes export.
Comments suppressed due to low confidence (1)

OneRosterSampleDataGenerator/Models/Exports/DemographicFile.cs:39

  • The demographics.csv header name for state of birth is currently "stateofBirthAbbreviation", but the repository spec doc (docs/plan.md) calls for "stateOfBirthAbbreviation". This mismatch can break consumers that expect the spec header.
    public string HispanicOrLatinoEthnicity { get; set; } = null!;
    [Name("countryOfBirthCode")]
    public string CountryOfBirthCode { get; set; } = null!;
    [Name("stateofBirthAbbreviation")]
    public string StateofBirthAbbreviation { get; set; } = null!;

Comment thread OneRosterSampleDataGenerator/Models/Exports/DemographicFile.cs
Comment thread OneRosterSampleDataGenerator/Models/Exports/DemographicFile.cs
Comment thread OneRosterSampleDataGenerator/Models/Exports/EnrollmentFile.cs
Added Asian property to Demographic and export mapping. Fixed typo: HispanicOrLationEthnicity → HispanicOrLatinoEthnicity. Moved courseSourcedId to end of EnrollmentFile export for correct output order.
@bergerb
bergerb merged commit 6b9ebb0 into main Jul 10, 2026
@bergerb
bergerb deleted the 51-add-missing-demographicscsv-columns-white-demographicracetwoormoreraces-hispanicorlatinoethnicity branch July 10, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment