Surface missing optional configMap/secret volumes in Pod output#709
Merged
Conversation
A configMap/secret volume with optional:true whose object is missing was silently ignored, even though it's useful diagnostic information (kubelet mounts it empty rather than blocking the pod). Now it renders a distinct "optional, not found" note and, like other volume problems, shows up without needing --include-all-volumes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optional: truewhose referenced object is missing was previously ignored entirely, even though it's useful diagnostic info.optional, not foundnote (not styled as an error, since kubelet mounts it empty rather than blocking the pod) and, like other volume problems, shows up without needing--include-all-volumes.doesn't existerror.Test plan
go build ./...go test ./...(457 tests, offline/golden suite)pod-volume-configmap-secret-optional-missing.regexand the correspondingTestE2EParallelsubtest to drop--include-all-volumesand assert the new note (verified regex logic against synthetic samples matching the template's single-line/multi-line volume rendering)