chore: remove remaining C# remnants (test/csharp, docs pages, dead SWIG branch) - #129
Merged
Conversation
Follow-up to the C# binding removal — clean up what was missed: - test/csharp/ (54 NUnit C# test files) removed. The one non-C# item there, the old-format upgrade fixture bdb4.7.db, was collateral; relocated to test/db/fixtures/ and run_upgrade.sh repointed (it's a 4.7 format DB, nothing to do with C#). - docs_src: drop the C# pages (build_win_csharp.md, programmer_reference/ csharp.md), their _meta.toml nav entries, and the dangling links to them in the install + programmer-reference indexes (STL renumbered to chapter 6). Historical C# mentions in the changelog pages are left (accurate history). - lang/java/libdb_java/db.i: drop the dead #elif SWIGCSHARP branch (db_csharp.i no longer exists; the guard was never defined post-removal). Dormant Oracle-era dist packaging (winmsi/win_projects/buildpkg) still names C# but is out of the make/ninja/nix flow; left untouched. docs build clean, no dangling C# links.
Coccinelle convention checksNo new violations. ✅ Resolved since baseline (2) -- update dist/cocci/baseline.txt to lock these in. |
ABI diff vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the C# binding removal — clean up what the first pass missed:
test/csharp/(54 NUnit C# test files) removed. The one non-C# item there, the old-format upgrade fixturebdb4.7.db, was collateral — relocated totest/db/fixtures/andrun_upgrade.shrepointed (it's a 4.7-format DB, unrelated to C#).build_win_csharp.md,programmer_reference/csharp.md), their_meta.tomlnav entries, and the dangling links in the install + programmer-reference indexes (STL renumbered to chapter 6). Historical C# mentions in the changelog pages are kept (accurate history).lang/java/libdb_java/db.i: drop the dead#elif SWIGCSHARPbranch (db_csharp.ino longer exists).Dormant Oracle-era dist packaging (winmsi/win_projects/buildpkg) still names C# but is out of the make/ninja/nix flow; left untouched. Docs build clean, no dangling C# links.